From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23F1C432BE for ; Mon, 26 Jul 2021 23:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA0BF60525 for ; Mon, 26 Jul 2021 23:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233805AbhGZWVk (ORCPT ); Mon, 26 Jul 2021 18:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233644AbhGZWVj (ORCPT ); Mon, 26 Jul 2021 18:21:39 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72DBBC061764 for ; Mon, 26 Jul 2021 16:02:06 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id c2-20020a0568303482b029048bcf4c6bd9so10243320otu.8 for ; Mon, 26 Jul 2021 16:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=YQOUs6IHKvgmEEaJoamgZLDtUOOWcnZjqqyzNqPHtgA=; b=X7ukQguYL+MKBPkBFhO7H5nfKnc70OCDuiDFR7YSf6QZLoLc4ReLFF6oY/7WEAPpeS PFJCBGADy/cvzKcTOc1MuVUHe+mO9raKPlB3JjjxQuitmjuPBprCfWobERLCeG8YR46C HBZgujM21DWWX2fFg3Zb81ftslEqmBez79Y5o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=YQOUs6IHKvgmEEaJoamgZLDtUOOWcnZjqqyzNqPHtgA=; b=TJbFqN70DFo64p6pNJ6UNT+HpJ01zFei7RBeJPnPiFkfs++DQGTUW1XXtwsPNFU1o8 7vtmogzlA38+pIGnmVr9okZGDu4WgM4tRMQ+NaPu73gSMKt+mclIs9i9MKw9oLg4WX+K eCcrFkA3HVXkzpxYYIGWWpz1rus1cDr3Qy6iJv3MT0Ccw1VuZlHt8iNOyNNuIy3yZtx8 GycrpJYIyTw4sU/k+lKX7iWAcXDs00vylDpmfw2CdjucwGLPV55b+kggPU3Rj3P9TeFK KZfc4vQX2FNaappH3ws5SlTHEbCobJx/Pq/TvtRYK/Rd9diq7Y1gfi8yyredylwlPwG5 S6LQ== X-Gm-Message-State: AOAM531e4aXxcv4LIgpTJE1gTcwZI99zdn5AGZh4Vcln2zI0PdaZP/qm 4Vl45NuaNtLCQ7m6ji8PT3DB1yz7eF4HQfQwgCmTaQ== X-Google-Smtp-Source: ABdhPJz5jt91J7s64KRcgC3G/srUYZuXPZrU0BBg8ga7AFXoIHLQ4iQUzviPocNr4D2zmNt8R5pRz0hfblCs9cIwm10= X-Received: by 2002:a9d:1b6e:: with SMTP id l101mr13153554otl.34.1627340525819; Mon, 26 Jul 2021 16:02:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 26 Jul 2021 19:02:05 -0400 MIME-Version: 1.0 In-Reply-To: <20210725031414.3961227-1-bjorn.andersson@linaro.org> References: <20210725031414.3961227-1-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 26 Jul 2021 19:02:05 -0400 Message-ID: Subject: Re: [PATCH] interconnect: qcom: osm-l3: Use driver-specific naming To: Bjorn Andersson , Georgi Djakov Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Bjorn Andersson (2021-07-24 20:14:14) > In situations were the developer screws up by e.g. not giving the OSM > nodes unique identifiers the interconnect framework might mix up nodes > between the OSM L3 provider and e.g. the RPMh provider. > > The resulting callstack containts "qcom_icc_set", which is not unique to > the OSM L3 provider driver. Once the faulting qcom_icc_set() is > identified it's further confusing that "qcom_icc_node" is different > between the different drivers. > > To avoid this confusion, rename the node struct and the setter in the > OSM L3 driver to include "osm_l3" in their names. > > Signed-off-by: Bjorn Andersson > --- Thanks Reviewed-by: Stephen Boyd