linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
@ 2021-07-24 17:29 Akhil P Oommen
  2021-07-27  0:16 ` Stephen Boyd
  0 siblings, 1 reply; 6+ messages in thread
From: Akhil P Oommen @ 2021-07-24 17:29 UTC (permalink / raw)
  To: freedreno, dri-devel,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm,
	Stephen Boyd, Bjorn Andersson, Rob Herring
  Cc: Jonathan Marek, Douglas Anderson, Jordan Crouse,
	Matthias Kaehlcke, Rob Clark, Andy Gross, linux-kernel

Add the necessary dt nodes for gpu support in sc7280.

Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
---
This patch has dependency on the GPUCC bindings patch here:
https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/

Changes in v2:
- formatting update and removed a duplicate header (Stephan)

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 116 +++++++++++++++++++++++++++++++++++
 1 file changed, 116 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 029723a..524a5e0 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,gpucc-sc7280.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/interconnect/qcom,sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -585,6 +586,121 @@
 			#clock-cells = <1>;
 		};
 
+		gpu@3d00000 {
+			compatible = "qcom,adreno-635.0", "qcom,adreno";
+			#stream-id-cells = <16>;
+			reg = <0 0x03d00000 0 0x40000>,
+			      <0 0x03d9e000 0 0x1000>,
+			      <0 0x03d61000 0 0x800>;
+			reg-names = "kgsl_3d0_reg_memory",
+				    "cx_mem",
+				    "cx_dbgc";
+			interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
+			iommus = <&adreno_smmu 0 0x401>;
+			operating-points-v2 = <&gpu_opp_table>;
+			qcom,gmu = <&gmu>;
+			interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
+			interconnect-names = "gfx-mem";
+
+			gpu_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-550000000 {
+					opp-hz = /bits/ 64 <550000000>;
+					opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
+					opp-peak-kBps = <6832000>;
+				};
+
+				opp-450000000 {
+					opp-hz = /bits/ 64 <450000000>;
+					opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
+					opp-peak-kBps = <4068000>;
+				};
+
+				opp-315000000 {
+					opp-hz = /bits/ 64 <315000000>;
+					opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
+					opp-peak-kBps = <1804000>;
+				};
+			};
+		};
+
+		gmu: gmu@3d69000 {
+			compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu";
+			reg = <0 0x03d6a000 0 0x34000>,
+				<0 0x3de0000 0 0x10000>,
+				<0 0x0b290000 0 0x10000>;
+			reg-names = "gmu", "rscc", "gmu_pdc";
+			interrupts = <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "hfi", "gmu";
+			clocks = <&gpucc GPU_CC_CX_GMU_CLK>,
+					<&gpucc GPU_CC_CXO_CLK>,
+					<&gcc GCC_DDRSS_GPU_AXI_CLK>,
+					<&gcc GCC_GPU_MEMNOC_GFX_CLK>,
+					<&gpucc GPU_CC_AHB_CLK>,
+					<&gpucc GPU_CC_HUB_CX_INT_CLK>,
+					<&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>;
+			clock-names = "gmu",
+				      "cxo",
+				      "axi",
+				      "memnoc",
+				      "ahb",
+				      "hub",
+				      "smmu_vote";
+			power-domains = <&gpucc GPU_CC_CX_GDSC>,
+					<&gpucc GPU_CC_GX_GDSC>;
+			power-domain-names = "cx",
+					     "gx";
+			iommus = <&adreno_smmu 5 0x400>;
+			operating-points-v2 = <&gmu_opp_table>;
+
+			gmu_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-200000000 {
+					opp-hz = /bits/ 64 <200000000>;
+					opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
+				};
+			};
+		};
+
+		adreno_smmu: iommu@3da0000 {
+			compatible = "qcom,sc7280-smmu-500", "qcom,adreno-smmu", "arm,mmu-500";
+			reg = <0 0x03da0000 0 0x20000>;
+			#iommu-cells = <2>;
+			#global-interrupts = <2>;
+			interrupts = <GIC_SPI 673 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 675 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 678 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 679 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 680 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 681 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 682 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 683 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 684 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 685 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 686 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 687 IRQ_TYPE_LEVEL_HIGH>;
+
+			clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>,
+					<&gcc GCC_GPU_SNOC_DVM_GFX_CLK>,
+					<&gpucc GPU_CC_AHB_CLK>,
+					<&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>,
+					<&gpucc GPU_CC_CX_GMU_CLK>,
+					<&gpucc GPU_CC_HUB_CX_INT_CLK>,
+					<&gpucc GPU_CC_HUB_AON_CLK>;
+			clock-names = "gcc_gpu_memnoc_gfx_clk",
+					"gcc_gpu_snoc_dvm_gfx_clk",
+					"gpu_cc_ahb_clk",
+					"gpu_cc_hlos1_vote_gpu_smmu_clk",
+					"gpu_cc_cx_gmu_clk",
+					"gpu_cc_hub_cx_int_clk",
+					"gpu_cc_hub_aon_clk";
+
+			power-domains = <&gpucc GPU_CC_CX_GDSC>;
+		};
+
 		lpass_ag_noc: interconnect@3c40000 {
 			reg = <0 0x03c40000 0 0xf080>;
 			compatible = "qcom,sc7280-lpass-ag-noc";
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
  2021-07-24 17:29 [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support Akhil P Oommen
@ 2021-07-27  0:16 ` Stephen Boyd
  2021-07-28  7:17   ` Akhil P Oommen
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2021-07-27  0:16 UTC (permalink / raw)
  To: Akhil P Oommen, Bjorn Andersson,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring,
	dri-devel, freedreno, linux-arm-msm
  Cc: Jonathan Marek, Douglas Anderson, Jordan Crouse,
	Matthias Kaehlcke, Rob Clark, Andy Gross, linux-kernel

Quoting Akhil P Oommen (2021-07-24 10:29:00)
> Add the necessary dt nodes for gpu support in sc7280.
>
> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> ---
> This patch has dependency on the GPUCC bindings patch here:
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/

To avoid the dependency the plain numbers can be used.

>
> Changes in v2:
> - formatting update and removed a duplicate header (Stephan)
>
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 116 +++++++++++++++++++++++++++++++++++
>  1 file changed, 116 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 029723a..524a5e0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -585,6 +586,121 @@
>                         #clock-cells = <1>;
>                 };
>
> +               gpu@3d00000 {
> +                       compatible = "qcom,adreno-635.0", "qcom,adreno";
> +                       #stream-id-cells = <16>;
> +                       reg = <0 0x03d00000 0 0x40000>,
> +                             <0 0x03d9e000 0 0x1000>,
> +                             <0 0x03d61000 0 0x800>;
> +                       reg-names = "kgsl_3d0_reg_memory",
> +                                   "cx_mem",
> +                                   "cx_dbgc";
> +                       interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
> +                       iommus = <&adreno_smmu 0 0x401>;
> +                       operating-points-v2 = <&gpu_opp_table>;
> +                       qcom,gmu = <&gmu>;
> +                       interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
> +                       interconnect-names = "gfx-mem";
> +
> +                       gpu_opp_table: opp-table {
> +                               compatible = "operating-points-v2";
> +
> +                               opp-550000000 {
> +                                       opp-hz = /bits/ 64 <550000000>;
> +                                       opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
> +                                       opp-peak-kBps = <6832000>;
> +                               };
> +
> +                               opp-450000000 {
> +                                       opp-hz = /bits/ 64 <450000000>;
> +                                       opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
> +                                       opp-peak-kBps = <4068000>;
> +                               };
> +
> +                               opp-315000000 {
> +                                       opp-hz = /bits/ 64 <315000000>;
> +                                       opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
> +                                       opp-peak-kBps = <1804000>;
> +                               };
> +                       };
> +               };
> +
> +               gmu: gmu@3d69000 {
> +                       compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu";
> +                       reg = <0 0x03d6a000 0 0x34000>,
> +                               <0 0x3de0000 0 0x10000>,
> +                               <0 0x0b290000 0 0x10000>;
> +                       reg-names = "gmu", "rscc", "gmu_pdc";
> +                       interrupts = <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "hfi", "gmu";
> +                       clocks = <&gpucc GPU_CC_CX_GMU_CLK>,
> +                                       <&gpucc GPU_CC_CXO_CLK>,
> +                                       <&gcc GCC_DDRSS_GPU_AXI_CLK>,
> +                                       <&gcc GCC_GPU_MEMNOC_GFX_CLK>,
> +                                       <&gpucc GPU_CC_AHB_CLK>,
> +                                       <&gpucc GPU_CC_HUB_CX_INT_CLK>,
> +                                       <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>;
> +                       clock-names = "gmu",
> +                                     "cxo",
> +                                     "axi",
> +                                     "memnoc",
> +                                     "ahb",
> +                                     "hub",
> +                                     "smmu_vote";
> +                       power-domains = <&gpucc GPU_CC_CX_GDSC>,
> +                                       <&gpucc GPU_CC_GX_GDSC>;
> +                       power-domain-names = "cx",
> +                                            "gx";
> +                       iommus = <&adreno_smmu 5 0x400>;
> +                       operating-points-v2 = <&gmu_opp_table>;
> +
> +                       gmu_opp_table: opp-table {
> +                               compatible = "operating-points-v2";
> +
> +                               opp-200000000 {
> +                                       opp-hz = /bits/ 64 <200000000>;
> +                                       opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
> +                               };
> +                       };
> +               };
> +
> +               adreno_smmu: iommu@3da0000 {
> +                       compatible = "qcom,sc7280-smmu-500", "qcom,adreno-smmu", "arm,mmu-500";
> +                       reg = <0 0x03da0000 0 0x20000>;
> +                       #iommu-cells = <2>;
> +                       #global-interrupts = <2>;
> +                       interrupts = <GIC_SPI 673 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 675 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 678 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 679 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 680 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 681 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 682 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 683 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 684 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 685 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 686 IRQ_TYPE_LEVEL_HIGH>,
> +                                       <GIC_SPI 687 IRQ_TYPE_LEVEL_HIGH>;
> +
> +                       clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>,
> +                                       <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>,
> +                                       <&gpucc GPU_CC_AHB_CLK>,
> +                                       <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>,
> +                                       <&gpucc GPU_CC_CX_GMU_CLK>,
> +                                       <&gpucc GPU_CC_HUB_CX_INT_CLK>,
> +                                       <&gpucc GPU_CC_HUB_AON_CLK>;
> +                       clock-names = "gcc_gpu_memnoc_gfx_clk",
> +                                       "gcc_gpu_snoc_dvm_gfx_clk",
> +                                       "gpu_cc_ahb_clk",
> +                                       "gpu_cc_hlos1_vote_gpu_smmu_clk",
> +                                       "gpu_cc_cx_gmu_clk",
> +                                       "gpu_cc_hub_cx_int_clk",
> +                                       "gpu_cc_hub_aon_clk";
> +
> +                       power-domains = <&gpucc GPU_CC_CX_GDSC>;
> +               };
> +
>                 lpass_ag_noc: interconnect@3c40000 {

This node is 3c40000 and the one above is 3da0000. 3c comes before 3d.
Please order nodes properly.

>                         reg = <0 0x03c40000 0 0xf080>;
>                         compatible = "qcom,sc7280-lpass-ag-noc";

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
  2021-07-27  0:16 ` Stephen Boyd
@ 2021-07-28  7:17   ` Akhil P Oommen
  2021-07-29 17:16     ` Stephen Boyd
  0 siblings, 1 reply; 6+ messages in thread
From: Akhil P Oommen @ 2021-07-28  7:17 UTC (permalink / raw)
  To: Stephen Boyd, Bjorn Andersson,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring,
	dri-devel, freedreno, linux-arm-msm
  Cc: Jonathan Marek, linux-kernel, Douglas Anderson, Jordan Crouse,
	Andy Gross, Matthias Kaehlcke

On 7/27/2021 5:46 AM, Stephen Boyd wrote:
> Quoting Akhil P Oommen (2021-07-24 10:29:00)
>> Add the necessary dt nodes for gpu support in sc7280.
>>
>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
>> ---
>> This patch has dependency on the GPUCC bindings patch here:
>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/
> 
> To avoid the dependency the plain numbers can be used.

But, won't that reduce readability and make things prone to error? If 
the other patch doesn't get picked up soon, we should try this option. 
We like to get this patch merged in v5.15.

> 
>>
>> Changes in v2:
>> - formatting update and removed a duplicate header (Stephan)
>>
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 116 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 116 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 029723a..524a5e0 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -585,6 +586,121 @@
>>                          #clock-cells = <1>;
>>                  };
>>
>> +               gpu@3d00000 {
>> +                       compatible = "qcom,adreno-635.0", "qcom,adreno";
>> +                       #stream-id-cells = <16>;
>> +                       reg = <0 0x03d00000 0 0x40000>,
>> +                             <0 0x03d9e000 0 0x1000>,
>> +                             <0 0x03d61000 0 0x800>;
>> +                       reg-names = "kgsl_3d0_reg_memory",
>> +                                   "cx_mem",
>> +                                   "cx_dbgc";
>> +                       interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
>> +                       iommus = <&adreno_smmu 0 0x401>;
>> +                       operating-points-v2 = <&gpu_opp_table>;
>> +                       qcom,gmu = <&gmu>;
>> +                       interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
>> +                       interconnect-names = "gfx-mem";
>> +
>> +                       gpu_opp_table: opp-table {
>> +                               compatible = "operating-points-v2";
>> +
>> +                               opp-550000000 {
>> +                                       opp-hz = /bits/ 64 <550000000>;
>> +                                       opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
>> +                                       opp-peak-kBps = <6832000>;
>> +                               };
>> +
>> +                               opp-450000000 {
>> +                                       opp-hz = /bits/ 64 <450000000>;
>> +                                       opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
>> +                                       opp-peak-kBps = <4068000>;
>> +                               };
>> +
>> +                               opp-315000000 {
>> +                                       opp-hz = /bits/ 64 <315000000>;
>> +                                       opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
>> +                                       opp-peak-kBps = <1804000>;
>> +                               };
>> +                       };
>> +               };
>> +
>> +               gmu: gmu@3d69000 {
>> +                       compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu";
>> +                       reg = <0 0x03d6a000 0 0x34000>,
>> +                               <0 0x3de0000 0 0x10000>,
>> +                               <0 0x0b290000 0 0x10000>;
>> +                       reg-names = "gmu", "rscc", "gmu_pdc";
>> +                       interrupts = <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
>> +                       interrupt-names = "hfi", "gmu";
>> +                       clocks = <&gpucc GPU_CC_CX_GMU_CLK>,
>> +                                       <&gpucc GPU_CC_CXO_CLK>,
>> +                                       <&gcc GCC_DDRSS_GPU_AXI_CLK>,
>> +                                       <&gcc GCC_GPU_MEMNOC_GFX_CLK>,
>> +                                       <&gpucc GPU_CC_AHB_CLK>,
>> +                                       <&gpucc GPU_CC_HUB_CX_INT_CLK>,
>> +                                       <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>;
>> +                       clock-names = "gmu",
>> +                                     "cxo",
>> +                                     "axi",
>> +                                     "memnoc",
>> +                                     "ahb",
>> +                                     "hub",
>> +                                     "smmu_vote";
>> +                       power-domains = <&gpucc GPU_CC_CX_GDSC>,
>> +                                       <&gpucc GPU_CC_GX_GDSC>;
>> +                       power-domain-names = "cx",
>> +                                            "gx";
>> +                       iommus = <&adreno_smmu 5 0x400>;
>> +                       operating-points-v2 = <&gmu_opp_table>;
>> +
>> +                       gmu_opp_table: opp-table {
>> +                               compatible = "operating-points-v2";
>> +
>> +                               opp-200000000 {
>> +                                       opp-hz = /bits/ 64 <200000000>;
>> +                                       opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
>> +                               };
>> +                       };
>> +               };
>> +
>> +               adreno_smmu: iommu@3da0000 {
>> +                       compatible = "qcom,sc7280-smmu-500", "qcom,adreno-smmu", "arm,mmu-500";
>> +                       reg = <0 0x03da0000 0 0x20000>;
>> +                       #iommu-cells = <2>;
>> +                       #global-interrupts = <2>;
>> +                       interrupts = <GIC_SPI 673 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 675 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 678 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 679 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 680 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 681 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 682 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 683 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 684 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 685 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 686 IRQ_TYPE_LEVEL_HIGH>,
>> +                                       <GIC_SPI 687 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +                       clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>,
>> +                                       <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>,
>> +                                       <&gpucc GPU_CC_AHB_CLK>,
>> +                                       <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>,
>> +                                       <&gpucc GPU_CC_CX_GMU_CLK>,
>> +                                       <&gpucc GPU_CC_HUB_CX_INT_CLK>,
>> +                                       <&gpucc GPU_CC_HUB_AON_CLK>;
>> +                       clock-names = "gcc_gpu_memnoc_gfx_clk",
>> +                                       "gcc_gpu_snoc_dvm_gfx_clk",
>> +                                       "gpu_cc_ahb_clk",
>> +                                       "gpu_cc_hlos1_vote_gpu_smmu_clk",
>> +                                       "gpu_cc_cx_gmu_clk",
>> +                                       "gpu_cc_hub_cx_int_clk",
>> +                                       "gpu_cc_hub_aon_clk";
>> +
>> +                       power-domains = <&gpucc GPU_CC_CX_GDSC>;
>> +               };
>> +
>>                  lpass_ag_noc: interconnect@3c40000 {
> 
> This node is 3c40000 and the one above is 3da0000. 3c comes before 3d.
> Please order nodes properly.

Yeah, I messed up the order at a couple of places. Will fix.

-Akhil.
> 
>>                          reg = <0 0x03c40000 0 0xf080>;
>>                          compatible = "qcom,sc7280-lpass-ag-noc";


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
  2021-07-28  7:17   ` Akhil P Oommen
@ 2021-07-29 17:16     ` Stephen Boyd
  2021-07-29 18:57       ` Akhil P Oommen
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2021-07-29 17:16 UTC (permalink / raw)
  To: Akhil P Oommen, Bjorn Andersson,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring,
	dri-devel, freedreno, linux-arm-msm
  Cc: Jonathan Marek, linux-kernel, Douglas Anderson, Jordan Crouse,
	Andy Gross, Matthias Kaehlcke

Quoting Akhil P Oommen (2021-07-28 00:17:45)
> On 7/27/2021 5:46 AM, Stephen Boyd wrote:
> > Quoting Akhil P Oommen (2021-07-24 10:29:00)
> >> Add the necessary dt nodes for gpu support in sc7280.
> >>
> >> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> >> ---
> >> This patch has dependency on the GPUCC bindings patch here:
> >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/
> >
> > To avoid the dependency the plain numbers can be used.
>
> But, won't that reduce readability and make things prone to error?

The numbers are not supposed to change so maybe it reduces readability
but I don't see how it is prone to error.

> If
> the other patch doesn't get picked up soon, we should try this option.
> We like to get this patch merged in v5.15.

The clk binding is already picked up but Bjorn would need to merge it
into the qcom tree to use it. I don't know what the plan is there.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
  2021-07-29 17:16     ` Stephen Boyd
@ 2021-07-29 18:57       ` Akhil P Oommen
  2021-07-29 19:02         ` Stephen Boyd
  0 siblings, 1 reply; 6+ messages in thread
From: Akhil P Oommen @ 2021-07-29 18:57 UTC (permalink / raw)
  To: Stephen Boyd, Bjorn Andersson,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring,
	dri-devel, freedreno, linux-arm-msm
  Cc: Jonathan Marek, linux-kernel, Douglas Anderson, Jordan Crouse,
	Andy Gross, Matthias Kaehlcke

On 7/29/2021 10:46 PM, Stephen Boyd wrote:
> Quoting Akhil P Oommen (2021-07-28 00:17:45)
>> On 7/27/2021 5:46 AM, Stephen Boyd wrote:
>>> Quoting Akhil P Oommen (2021-07-24 10:29:00)
>>>> Add the necessary dt nodes for gpu support in sc7280.
>>>>
>>>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
>>>> ---
>>>> This patch has dependency on the GPUCC bindings patch here:
>>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/
>>>
>>> To avoid the dependency the plain numbers can be used.
>>
>> But, won't that reduce readability and make things prone to error?
> 
> The numbers are not supposed to change so maybe it reduces readability
> but I don't see how it is prone to error.

I cross check GPU's clock list whenever there is a system level issue 
like NoC errors. So it is convenient to have the clock names here, at 
least for me. But, I will budge if it is not easy to manage the dependency.

> 
>> If
>> the other patch doesn't get picked up soon, we should try this option.
>> We like to get this patch merged in v5.15.
> 
> The clk binding is already picked up but Bjorn would need to merge it
> into the qcom tree to use it. I don't know what the plan is there.
> 

Bjorn, could you please advise here?

-Akhil.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
  2021-07-29 18:57       ` Akhil P Oommen
@ 2021-07-29 19:02         ` Stephen Boyd
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-07-29 19:02 UTC (permalink / raw)
  To: Akhil P Oommen, Bjorn Andersson,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring,
	dri-devel, freedreno, linux-arm-msm
  Cc: Jonathan Marek, linux-kernel, Douglas Anderson, Jordan Crouse,
	Andy Gross, Matthias Kaehlcke

Quoting Akhil P Oommen (2021-07-29 11:57:23)
> On 7/29/2021 10:46 PM, Stephen Boyd wrote:
> > Quoting Akhil P Oommen (2021-07-28 00:17:45)
> >> On 7/27/2021 5:46 AM, Stephen Boyd wrote:
> >>> Quoting Akhil P Oommen (2021-07-24 10:29:00)
> >>>> Add the necessary dt nodes for gpu support in sc7280.
> >>>>
> >>>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> >>>> ---
> >>>> This patch has dependency on the GPUCC bindings patch here:
> >>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/
> >>>
> >>> To avoid the dependency the plain numbers can be used.
> >>
> >> But, won't that reduce readability and make things prone to error?
> >
> > The numbers are not supposed to change so maybe it reduces readability
> > but I don't see how it is prone to error.
>
> I cross check GPU's clock list whenever there is a system level issue
> like NoC errors. So it is convenient to have the clock names here, at
> least for me. But, I will budge if it is not easy to manage the dependency.

To clarify my statement, the defines can be used eventually once the
header file is part of the same tree. A duplicate patch between clk and
qcom trees is fine or pulling in the clk branch works too.

>
> >
> >> If
> >> the other patch doesn't get picked up soon, we should try this option.
> >> We like to get this patch merged in v5.15.
> >
> > The clk binding is already picked up but Bjorn would need to merge it
> > into the qcom tree to use it. I don't know what the plan is there.
> >
>
> Bjorn, could you please advise here?
>
> -Akhil.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-29 19:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24 17:29 [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support Akhil P Oommen
2021-07-27  0:16 ` Stephen Boyd
2021-07-28  7:17   ` Akhil P Oommen
2021-07-29 17:16     ` Stephen Boyd
2021-07-29 18:57       ` Akhil P Oommen
2021-07-29 19:02         ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).