From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C702C4320E for ; Thu, 29 Jul 2021 19:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E288B60FE7 for ; Thu, 29 Jul 2021 19:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbhG2TCU (ORCPT ); Thu, 29 Jul 2021 15:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229925AbhG2TCS (ORCPT ); Thu, 29 Jul 2021 15:02:18 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D75BC0613C1 for ; Thu, 29 Jul 2021 12:02:15 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id z26so9745186oih.10 for ; Thu, 29 Jul 2021 12:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=Su69e0VwCDTVXaZGqAhM3F7LtZETVHlakvlYKvoZayM=; b=SebcM8G3BBQpdbYfLQP0sdWaVQX0nFTrotqhmuGnCKbjKWaSNqupvYNVRfuM7GhE5z LbpWNsB4ztjfjw6ymIQKoHysAEYtFeGSFdsbJ5mQSqQzMdhlctZh2XtEA5M99LcG/f3b lMmA1rH5F2+pMRgkFSwb5QYY8Dh708WIynYSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=Su69e0VwCDTVXaZGqAhM3F7LtZETVHlakvlYKvoZayM=; b=lRbrK7fqhjrIP27JzCVeMNyJzP3o91qSJw42+Z5a97j/4GQlI6HGKwlPpXdnYJFQ4B JBf9LAdpL9b/txl0pTlyKVdUAeKTBtTYJLuMwIkrLcaq5i3cEBd9nDgqMMGIj/ZSpRSz UotWDdG8orLKYbnJXCvvpplHrVuOJwcNPMJq4/oiLponJWWteY9H+AHNwrTDrlkzSWoC UhknQWfRGpYo3zCSa0N+EFvpf1JbiflpILT1NWxGaYUO5DnkFc9w1TDxrbW6Nn6/wbac yxCZ39kc0UVnqg9Xdgv3Tut8NZcuOn/YX758wQ8CXJ+vTtq4fZafDn1RorQ2ZZbFfNsV zDvw== X-Gm-Message-State: AOAM531Vn50SjGaUmmTIUDt7LU5EbcCC1eA11ep9VFieImSjUGv2btsc mH1mRonZ6WhQc/Y6PukM2irvzOEJTq7CUY1z3MmsLQ== X-Google-Smtp-Source: ABdhPJz7dbzotSQmyoBhO3gVd5uNSdiIKcidtDyg1R8EG+Y9ws7CEIXpDqoO0HYTgqDy8Fs8af2iAnOgsNNuQTnmwHI= X-Received: by 2002:a54:468d:: with SMTP id k13mr11054293oic.125.1627585334851; Thu, 29 Jul 2021 12:02:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 29 Jul 2021 12:02:14 -0700 MIME-Version: 1.0 In-Reply-To: <308d8f1e-9f23-9d78-42cc-a42ce3463027@codeaurora.org> References: <1627147740-11590-1-git-send-email-akhilpo@codeaurora.org> <308d8f1e-9f23-9d78-42cc-a42ce3463027@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 29 Jul 2021 12:02:14 -0700 Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support To: Akhil P Oommen , Bjorn Andersson , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Rob Herring , dri-devel@lists.freedesktop.org, freedreno , linux-arm-msm@vger.kernel.org Cc: Jonathan Marek , linux-kernel@vger.kernel.org, Douglas Anderson , Jordan Crouse , Andy Gross , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Akhil P Oommen (2021-07-29 11:57:23) > On 7/29/2021 10:46 PM, Stephen Boyd wrote: > > Quoting Akhil P Oommen (2021-07-28 00:17:45) > >> On 7/27/2021 5:46 AM, Stephen Boyd wrote: > >>> Quoting Akhil P Oommen (2021-07-24 10:29:00) > >>>> Add the necessary dt nodes for gpu support in sc7280. > >>>> > >>>> Signed-off-by: Akhil P Oommen > >>>> --- > >>>> This patch has dependency on the GPUCC bindings patch here: > >>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/ > >>> > >>> To avoid the dependency the plain numbers can be used. > >> > >> But, won't that reduce readability and make things prone to error? > > > > The numbers are not supposed to change so maybe it reduces readability > > but I don't see how it is prone to error. > > I cross check GPU's clock list whenever there is a system level issue > like NoC errors. So it is convenient to have the clock names here, at > least for me. But, I will budge if it is not easy to manage the dependency. To clarify my statement, the defines can be used eventually once the header file is part of the same tree. A duplicate patch between clk and qcom trees is fine or pulling in the clk branch works too. > > > > >> If > >> the other patch doesn't get picked up soon, we should try this option. > >> We like to get this patch merged in v5.15. > > > > The clk binding is already picked up but Bjorn would need to merge it > > into the qcom tree to use it. I don't know what the plan is there. > > > > Bjorn, could you please advise here? > > -Akhil.