From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09345C433EF for ; Tue, 7 Sep 2021 20:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E163961102 for ; Tue, 7 Sep 2021 20:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344206AbhIGUVb (ORCPT ); Tue, 7 Sep 2021 16:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232816AbhIGUVa (ORCPT ); Tue, 7 Sep 2021 16:21:30 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCFD1C061757 for ; Tue, 7 Sep 2021 13:20:23 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso598565otv.12 for ; Tue, 07 Sep 2021 13:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=ukPiPPE2rZ88vZN1HP1lB0rTF2OeXPBUpUGvxMb6w7A=; b=kyqoGXnxMsNL5PFmmBaRpA3fUSFzACYYEJxAgrqLqfisBC7GAJWkod8Uqn55/K35Mi yM23x2n0ovoqTTeaQJXg169ZYYouKU+wFJaCdxnSrs/TVE2An7bwq6vDk8vFjK/cjlL6 zFC7Yj++kgWDa/LOxFnG3zcLCHHyZSJ8anrw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=ukPiPPE2rZ88vZN1HP1lB0rTF2OeXPBUpUGvxMb6w7A=; b=f1CwIVKlp71x2iZS0EShwEN+pnoJOrexUwk/4A6qb59Mwok/KmDmY/KK+Gr3G1gZiE hebschcWWhkI01hS92YLEXuTFm2J40AnO02uI+4jnCz5Vsuexr1S2GjVw27vprvGAguS kUKbORerW4K8YYquE4a5gVickLJp9jpesrWQX/u6sXwoXXZhxj3rbbtMsMcl2z+U1bAn hsdFfvyU5OrY2vfPttNWa9IptcmeM6SkWmBN1/RSgNq5UNX+YJ5iVGWV3xY9Irf739XJ GgfhDFAzfLXGGBH/GNNcuDksbEMs5wHueXE/ncAaNFJIn4cVXli8JX9Xy79JfJlK5HJU 2tBA== X-Gm-Message-State: AOAM530tKR/V7S4F98cg/Al2bdBhg7uHP717XZckxYtlpKeN5I2D2Lqt cRjqlnOFAKRRkYWJW2lQhVASMVlDTYQn7+tDreppVw== X-Google-Smtp-Source: ABdhPJwYa1VNZ8SWZ957Teoa4i0325fu9DZgnTn3d3Vrdn657RvBqUeJFE1e8/tQPlx1wh3Bf/tNEWc0pG6yKORbGsk= X-Received: by 2002:a05:6830:719:: with SMTP id y25mr174735ots.77.1631046023013; Tue, 07 Sep 2021 13:20:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 7 Sep 2021 20:20:22 +0000 MIME-Version: 1.0 In-Reply-To: <1630924867-4663-3-git-send-email-skakit@codeaurora.org> References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-3-git-send-email-skakit@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 7 Sep 2021 20:20:22 +0000 Message-ID: Subject: Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver To: Andy Gross , Bjorn Andersson , Pavel Machek , Rob Herring , satya priya Cc: mka@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting satya priya (2021-09-06 03:41:06) > Add pm8350c compatible and lpg_data to the driver. > > Signed-off-by: satya priya > --- > drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index 327e81a..6ee80d6 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = { > }, > }; > > +static const struct lpg_data pm8350c_pwm_data = { > + .pwm_9bit_mask = BIT(2), > + > + .num_channels = 1, > + .channels = (struct lpg_channel_data[]) { Can this be const struct lpg_channel_data? I think that will move it to rodata which is only a good thing. > + { .base = 0xeb00 }, > + }, > +}; > + > static const struct of_device_id lpg_of_table[] = { > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, > { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, > { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },