From: Stephen Boyd <swboyd@chromium.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>,
agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org,
daniel@ffwll.ch, dmitry.baryshkov@linaro.org,
dri-devel@lists.freedesktop.org, robdclark@gmail.com,
sean@poorly.run, vkoul@kernel.org
Cc: quic_abhinavk@quicinc.com, aravindh@codeaurora.org,
quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received
Date: Fri, 14 Jan 2022 19:13:32 -0600 [thread overview]
Message-ID: <CAE-0n52KfpfnxsC5SKvR9zWWONmh2oyD3cS9L-8-J1RHHzKSdQ@mail.gmail.com> (raw)
In-Reply-To: <1642208315-9136-2-git-send-email-quic_khsieh@quicinc.com>
Quoting Kuogee Hsieh (2022-01-14 16:58:32)
> @@ -1363,14 +1368,14 @@ static int dp_pm_suspend(struct device *dev)
> if (dp_power_clk_status(dp->power, DP_CTRL_PM))
> dp_ctrl_off_link_stream(dp->ctrl);
>
> + dp_display_host_phy_exit(dp);
> +
> + /* host_init will be called at pm_resume */
> dp_display_host_deinit(dp);
> }
I thought we determined that core_initialized was always true here, so
the if condition is redundant. Furthermore, removing that check allows
us to entirely remove the core_initialized variable from the code.
next prev parent reply other threads:[~2022-01-15 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 0:58 [PATCH v17 0/4] group dp driver related patches into one series Kuogee Hsieh
2022-01-15 0:58 ` [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received Kuogee Hsieh
2022-01-15 1:13 ` Stephen Boyd [this message]
2022-01-17 18:16 ` Kuogee Hsieh
2022-01-15 0:58 ` [PATCH v17 2/4] drm/msm/dp: populate connector of struct dp_panel Kuogee Hsieh
2022-01-15 0:58 ` [PATCH v17 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 Kuogee Hsieh
2022-01-15 0:58 ` [PATCH v17 4/4] drm/msm/dp: stop link training after link training 2 failed Kuogee Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n52KfpfnxsC5SKvR9zWWONmh2oyD3cS9L-8-J1RHHzKSdQ@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=aravindh@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).