linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH v2] driver core: Make cycle dev_info() message dev_dbg()
Date: Fri, 4 Jun 2021 20:18:52 +0000	[thread overview]
Message-ID: <CAE-0n52SonMvf+c3YFt-u-LcrfOj4Nhg30JqyGyceSpdFhK2WA@mail.gmail.com> (raw)
In-Reply-To: <YLoj/2XmCo9OWjTS@kroah.com>

Quoting Greg Kroah-Hartman (2021-06-04 06:00:47)
> On Thu, Jun 03, 2021 at 01:21:16PM -0700, Stephen Boyd wrote:
> > This seems to mostly print debug information about device link stuff at
> > boot. It doesn't seem very useful outside of debugging so move it to
> > dev_dbg().
>
> What messages at boot time are you seeing with this that should not be
> there?  Shouldn't we fix the root cause here and not paper over it by
> just lowering the logging level?

Is there any problem? If they're a problem then shouldn't the printk be
at least warning level, pr_warn() if not pr_err()? I thought that
sometimes devices have cyclic links so we want to back off at that time
and stop trying.

>
> What drivers are having problems to trigger this?
>

It looks to be mostly the coresight devices that print this info message
for me. The other one is the display panel. The coresight devices are in
arch/arm64/boot/dts/qcom/sc7180.dtsi

[    0.545197] amba 6041000.funnel: Fixing up cyclic dependency with 6002000.stm
[    0.547173] amba 6045000.funnel: Fixing up cyclic dependency with
6042000.funnel
[    0.548032] amba 6045000.funnel: Fixing up cyclic dependency with
6041000.funnel
[    0.549899] amba 6048000.etr: Fixing up cyclic dependency with
6046000.replicator
[    0.551371] amba 6b04000.funnel: Fixing up cyclic dependency with
6045000.funnel
[    0.552781] amba 6b05000.etf: Fixing up cyclic dependency with 6b04000.funnel
[    0.554258] amba 6b06000.replicator: Fixing up cyclic dependency
with 6b05000.etf
[    0.555136] amba 6b06000.replicator: Fixing up cyclic dependency
with 6046000.replicator
[    0.560889] amba 7800000.funnel: Fixing up cyclic dependency with 7740000.etm
[    0.561726] amba 7800000.funnel: Fixing up cyclic dependency with 7640000.etm
[    0.562553] amba 7800000.funnel: Fixing up cyclic dependency with 7540000.etm
[    0.563388] amba 7800000.funnel: Fixing up cyclic dependency with 7440000.etm
[    0.564205] amba 7800000.funnel: Fixing up cyclic dependency with 7340000.etm
[    0.565034] amba 7800000.funnel: Fixing up cyclic dependency with 7240000.etm
[    0.565867] amba 7800000.funnel: Fixing up cyclic dependency with 7140000.etm
[    0.566693] amba 7800000.funnel: Fixing up cyclic dependency with 7040000.etm
[    0.568196] amba 7810000.funnel: Fixing up cyclic dependency with
7800000.funnel
[    0.569047] amba 7810000.funnel: Fixing up cyclic dependency with
6042000.funnel
[    0.623637] i2c 2-002d: Fixing up cyclic dependency with panel
[    1.108625] platform ae94000.dsi: Fixing up cyclic dependency with 2-002d
[    1.115646] platform ae94000.dsi: Fixing up cyclic dependency with
ae01000.mdp

I suppose with the graph binding making links we get these cyclic
dependency messages now.

      reply	other threads:[~2021-06-04 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 20:21 [PATCH v2] driver core: Make cycle dev_info() message dev_dbg() Stephen Boyd
2021-06-03 22:27 ` Saravana Kannan
2021-06-04 13:00 ` Greg Kroah-Hartman
2021-06-04 20:18   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE-0n52SonMvf+c3YFt-u-LcrfOj4Nhg30JqyGyceSpdFhK2WA@mail.gmail.com \
    --to=swboyd@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).