From: Stephen Boyd <swboyd@chromium.org>
To: khsieh@codeaurora.org
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org,
abhinavk@codeaurora.org, aravindh@codeaurora.org,
freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()
Date: Wed, 4 Aug 2021 09:24:34 -0700 [thread overview]
Message-ID: <CAE-0n52bpS4mxM+=xxXvxQYSc5p_xyhkPQ07E1ad9uM1ZBKLwA@mail.gmail.com> (raw)
In-Reply-To: <ab2a7aadb6ada58246ec972c4938c627@codeaurora.org>
Quoting khsieh@codeaurora.org (2021-08-04 08:48:04)
> On 2021-08-03 12:05, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-08-03 09:25:13)
> >> @@ -1327,14 +1327,26 @@ static int dp_pm_resume(struct device *dev)
> >>
> >> dp_catalog_ctrl_hpd_config(dp->catalog);
> >>
> >> - status = dp_catalog_link_is_connected(dp->catalog);
> >> + /*
> >> + * set sink to normal operation mode -- D0
> >> + * before dpcd read
> >> + */
> >> + dp_link_psm_config(dp->link, &dp->panel->link_info, false);
> >> +
> >> + /* if sink conencted, do dpcd read sink count */
> >
> > s/conencted/connected/
> >
> > This also just says what the code is doing. Why do we only read the
> > sink
> > count if the link is connected? Can we read the sink count even if the
> > link isn't connected and then consider sink count as 0 if trying to
> > read
> > fails?
> >
> yes, we can do that.
> But it will suffer aux time out and retry.
> i think it is better to avoid this overhead by check connection first.
>
Hmm ok. Maybe something is wrong with the aux channel where it doesn't
avoid the timeout if the connection is obviously not established yet.
prev parent reply other threads:[~2021-08-04 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 16:25 [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume() Kuogee Hsieh
2021-08-03 19:05 ` Stephen Boyd
2021-08-04 15:48 ` khsieh
2021-08-04 16:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n52bpS4mxM+=xxXvxQYSc5p_xyhkPQ07E1ad9uM1ZBKLwA@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=aravindh@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).