From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7C4C4332F for ; Tue, 12 Oct 2021 17:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 548366109E for ; Tue, 12 Oct 2021 17:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232221AbhJLR0Z (ORCPT ); Tue, 12 Oct 2021 13:26:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhJLR0X (ORCPT ); Tue, 12 Oct 2021 13:26:23 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1933DC061570 for ; Tue, 12 Oct 2021 10:24:20 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id s18-20020a0568301e1200b0054e77a16651so228386otr.7 for ; Tue, 12 Oct 2021 10:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=WtGUxGcFjuCHfdY5GXb0D0YOU0tDNV4fZPj+DPhXlYE=; b=Ygp4ifFUh4fnPgEXFZgBH9TuzFDWRciRle3R6C/OmN+Tc/gQLgSkXTXTbZRIdnddLR UlzAbrEJvydN+RLG9v95HhKmXtQ4EsNuUd3x32f2XMCsp23nzD6HWws72TAOktZCnwHl +N28WqLe+HezX9sOMCLZ84clVPeX8L0/dGnvk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=WtGUxGcFjuCHfdY5GXb0D0YOU0tDNV4fZPj+DPhXlYE=; b=id+ZRkZz72/SsgzHVvP+ZybiSOrrkbsiFVvhhCAQmY8dgkn6ckb7bFdHnwWS5+kQRt UE6wrcQdwIgPENIwkMWXUV+jm+HPA05QkioKr/7zuLioy1bfsI6L2x6PxQGnb0Iewd6h UIJJoQiX5XhSC7C13WqczC6ORmdXwE2PuHyphI+clh9PdmXFioFj7eme+7767CFJv1cg FinIO753DJ1a52xPgyCuf95Buv2RPZ/USz5w8TwIMtcMkMIpEZeVLn79VDnVwFd45Wam TQ+QhibYEPc3gXmkU4Rz6+HdbvWljUjy6dDq8/g5ff1pthVOeRmw3v431RRBUoRvJGo+ CXaw== X-Gm-Message-State: AOAM531DZjtzVQsetjl2c7QyJcC4HH6AuPmGswvVUhb4dfILthsIWdGl BwjJKnu3X5KHoZCgOeU2AJRDlM+sMmy6p9nqnL4G1Q== X-Google-Smtp-Source: ABdhPJyyzBj7ga+1h/1rc7fPUC6+eHYYeexKxLGfIUioGQJOYFkovXPDVM16Ib6kWcg+ovb2j2roI86MtptDRyCsa0g= X-Received: by 2002:a9d:12f4:: with SMTP id g107mr22637198otg.77.1634059459215; Tue, 12 Oct 2021 10:24:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Oct 2021 10:24:18 -0700 MIME-Version: 1.0 In-Reply-To: <1634043698-20256-1-git-send-email-bgodavar@codeaurora.org> References: <1634043698-20256-1-git-send-email-bgodavar@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 12 Oct 2021 10:24:18 -0700 Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 To: Balakrishna Godavarthi , bjorn.andersson@linaro.org, johan.hedberg@gmail.com, marcel@holtmann.org Cc: mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, pharish@codeaurora.org, rjliao@codeaurora.org, hbandi@codeaurora.org, saluvala@codeaurora.org, abhishekpandit@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Balakrishna Godavarthi (2021-10-12 06:01:38) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 272d5ca..09adc802 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -393,6 +393,23 @@ > <&tlmm 31 IRQ_TYPE_EDGE_FALLING>; > pinctrl-names = "default", "sleep"; > pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>; > + > + bluetooth: wcn6750-bt { bluetooth: bluetooth { Node names should be generic. > + compatible = "qcom,wcn6750-bt"; > + pinctrl-names = "default"; > + pinctrl-0 = <&bt_en_default>; > + enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>; > + swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>; Is there any pinctrl config for gpio 86? > + vddaon-supply = <&vreg_s7b_0p9>; > + vddbtcxmx-supply = <&vreg_s7b_0p9>; > + vddrfacmn-supply = <&vreg_s7b_0p9>; > + vddrfa0p8-supply = <&vreg_s7b_0p9>; > + vddrfa1p7-supply = <&vreg_s1b_1p8>; > + vddrfa1p2-supply = <&vreg_s8b_1p2>; > + vddrfa2p2-supply = <&vreg_s1c_2p2>; > + vddasd-supply = <&vreg_l11c_2p8>; > + max-speed = <3200000>; > + }; > }; > > /* PINCTRL - additions to nodes defined in sc7280.dtsi */ > @@ -504,6 +521,14 @@ > */ > bias-pull-up; > }; > + > + bt_en_default: bt_en_default { bt_en: bt-en { Node names shouldn't have underscores and 'default' is redundant. > + pins = "gpio85"; > + function = "gpio"; > + drive-strength = <2>; > + output-low; > + bias-pull-down; Why is there a pull down on an output gpio? Shouldn't this be bias-disable? > + }; > }; > > &sdc1_on {