From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADACC432BE for ; Tue, 10 Aug 2021 21:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E63B6108C for ; Tue, 10 Aug 2021 21:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234295AbhHJVcn (ORCPT ); Tue, 10 Aug 2021 17:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233968AbhHJVcl (ORCPT ); Tue, 10 Aug 2021 17:32:41 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F131C0613D3 for ; Tue, 10 Aug 2021 14:32:19 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id r19-20020a0568301353b029050aa53c3801so832777otq.2 for ; Tue, 10 Aug 2021 14:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=2TEOQGiAQW3LJuAkSRtxbwnZcRI4cSybco52ZSAwzug=; b=WVkAnSE/ZGx5+Eaqx1oMrPKB2m9ZEuZle+H2fzP31C8LKJ7blO9okOvrJLCQngLMh1 AYEXnqpEZNMcpoVL3zyjTy+UEMJ3ccQBkrS02f0R78bJPpVcVDwPjIUFcZFhCKtFnaMy x8wkpt8HDoL6UpxGKAo7IzrZcHaADNQahWkyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=2TEOQGiAQW3LJuAkSRtxbwnZcRI4cSybco52ZSAwzug=; b=f6Bp/u0WHeCrpSWZ2L5hce2rCa/zvmS17NoeWlNr+uBihINaxQZdoRJZ6D0IfYoATQ hVpHnftqyIwRQZMgMHUfusnTlsgiv13GkRVTgrdJGmMrnF7OBex3iKvft2AtBgiKUDar itvmJCUbO04xBrr2a/eEE43QEvaVt+9SmBnIQseYABmrXEHANZDV7/FY9KB4TMZVg6Ic PDB3jOBumobMBlgE2IftpLxH4A+G+C6990GOaL0DI6OlDAhrPNWiVl/aVchHp/IH2sAT 7A8QQQqCdQJAspDQqViMoBt9QhZKZGeJSv9YvivhmJa1eoVF3EBQVzQFWrb6/AC/U98A eGmg== X-Gm-Message-State: AOAM531/4e+KoBbzOBdXvUnCEIsihIKeNpv+4s4X3w/dqQ1ZSmtJzAZz h7ziGURtqcus5y4oL9++0g8KqewBpGCeIquOAvZeRQ== X-Google-Smtp-Source: ABdhPJzKuHGG5SEuOgiuv6zSynYUbXFakY1O5WFVDqIOV8i6nqaif26ZzTNpPcImURd0czHpta4tzT+W1oQ71p7UW1g= X-Received: by 2002:a05:6830:44a7:: with SMTP id r39mr22526030otv.25.1628631138739; Tue, 10 Aug 2021 14:32:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 Aug 2021 14:32:18 -0700 MIME-Version: 1.0 In-Reply-To: <1628196295-7382-3-git-send-email-khsieh@codeaurora.org> References: <1628196295-7382-1-git-send-email-khsieh@codeaurora.org> <1628196295-7382-3-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 10 Aug 2021 14:32:18 -0700 Message-ID: Subject: Re: [PATCH v3 2/6] drm/msm/dp: reduce link rate if failed at link training 1 To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kuogee Hsieh (2021-08-05 13:44:51) > Reduce link rate and re start link training if link training 1 > failed due to loss of clock recovery done to fix Link Layer > CTS case 4.3.1.7. Also only update voltage and pre-emphasis > swing level after link training started to fix Link Layer CTS > case 4.3.1.6. > > Changes in V2: > -- replaced cr_status with link_status[DP_LINK_STATUS_SIZE] > -- replaced dp_ctrl_any_lane_cr_done() with dp_ctrl_colco_recovery_any_ok() > -- replaced dp_ctrl_any_ane_cr_lose() with !drm_dp_clock_recovery_ok() > > Changes in V3: > -- return failed if lane_count <= 1 > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd