From: Stephen Boyd <swboyd@chromium.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Jordan Crouse <jordan@cosmicpenguin.net>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Marek <jonathan@marek.ca>, Emma Anholt <emma@anholt.net>,
Yangtao Li <tiny.windzz@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/msm: Add SYSPROF param
Date: Thu, 3 Mar 2022 12:47:10 -0800 [thread overview]
Message-ID: <CAE-0n532ZX=qXTBKSFyRYAmkqFN7oqKyPvJHBuVMmr2eHY+O4A@mail.gmail.com> (raw)
In-Reply-To: <20220303194758.710358-4-robdclark@gmail.com>
Quoting Rob Clark (2022-03-03 11:46:47)
> diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h
> index fde9a29f884e..0ba1dbd4e50f 100644
> --- a/drivers/gpu/drm/msm/msm_gpu.h
> +++ b/drivers/gpu/drm/msm/msm_gpu.h
> @@ -330,6 +337,24 @@ struct msm_file_private {
> struct kref ref;
> int seqno;
>
> + /**
> + * sysprof:
> + *
> + * The value of MSM_PARAM_SYSPROF set by userspace. This is
> + * intended to be used by system profiling tools like Mesa's
> + * pps-producer (perfetto), and restricted to CAP_SYS_ADMIN.
> + *
> + * Setting a value of 1 will preserve performance counters across
> + * context switches. Setting a value of 2 will in addition
> + * suppress suspend. (Performance counters loose state across
s/loose /lose/
> + * power collapse, which is undesirable for profiling in some
> + * cases.)
> + *
> + * The value automatically reverts to zero when the drm device
> + * file is closed.
> + */
> + int sysprof;
> +
> /**
> * elapsed:
> *
> diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c
> index 7cb158bcbcf6..4179db54ac93 100644
> --- a/drivers/gpu/drm/msm/msm_submitqueue.c
> +++ b/drivers/gpu/drm/msm/msm_submitqueue.c
> @@ -7,6 +7,40 @@
>
> #include "msm_gpu.h"
>
> +int msm_file_private_set_sysprof(struct msm_file_private *ctx,
> + struct msm_gpu *gpu, int sysprof)
> +{
> + /* unwind old value first: */
> + switch (ctx->sysprof) {
> + case 2:
> + pm_runtime_put_autosuspend(&gpu->pdev->dev);
> + fallthrough;
> + case 1:
> + refcount_dec(&gpu->sysprof_active);
> + fallthrough;
> + case 0:
> + break;
> + }
> +
> + /* then apply new value: */
It would be safer to swap this. Otherwise a set when the values are at
"1" would drop to "zero" here and potentially trigger some glitch,
whereas incrementing one more time and then dropping the previous state
would avoid that short blip.
> + switch (sysprof) {
> + default:
> + return -EINVAL;
This will become more complicated though.
> + case 2:
> + pm_runtime_get_sync(&gpu->pdev->dev);
> + fallthrough;
> + case 1:
> + refcount_inc(&gpu->sysprof_active);
> + fallthrough;
> + case 0:
> + break;
> + }
> +
> + ctx->sysprof = sysprof;
> +
> + return 0;
> +}
next prev parent reply other threads:[~2022-03-03 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 19:46 [PATCH 0/4] drm/msm: Clear perf counters across context switch Rob Clark
2022-03-03 19:46 ` [PATCH 1/4] drm/msm: Update generated headers Rob Clark
2022-03-03 20:42 ` Abhinav Kumar
2022-03-03 21:11 ` Rob Clark
2022-03-03 21:22 ` Abhinav Kumar
2022-03-03 19:46 ` [PATCH 2/4] drm/msm: Add SET_PARAM ioctl Rob Clark
2022-03-03 19:46 ` [PATCH 3/4] drm/msm: Add SYSPROF param Rob Clark
2022-03-03 20:47 ` Stephen Boyd [this message]
2022-03-03 21:17 ` Rob Clark
2022-03-03 21:47 ` Rob Clark
2022-03-03 22:36 ` Stephen Boyd
2022-03-03 19:46 ` [PATCH 4/4] drm/msm/a6xx: Zap counters across context switch Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n532ZX=qXTBKSFyRYAmkqFN7oqKyPvJHBuVMmr2eHY+O4A@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).