From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B761FC4320A for ; Tue, 10 Aug 2021 19:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E52960E76 for ; Tue, 10 Aug 2021 19:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232700AbhHJTwI (ORCPT ); Tue, 10 Aug 2021 15:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232071AbhHJTwH (ORCPT ); Tue, 10 Aug 2021 15:52:07 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD376C061798 for ; Tue, 10 Aug 2021 12:51:44 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id v10-20020a9d604a0000b02904fa9613b53dso454493otj.6 for ; Tue, 10 Aug 2021 12:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=7/7uowWN2jQeWDxt9eNITvpY2HZF5mcPTVHvPG/MbMQ=; b=gt5soBchXC72xOkvl3xRddt38dFwE4MTM7neiayM2G7uoE7Vh+uFyH1pTweQ2BpE9Q Q4w5KNBCV+MXPzZFKDUOdVp8I27Pso4vAIjC1Y3fqdgwnDdWbhWwt0UCI/75EqbcugPd QZxGFJby0phDcPWiQGZFgdVSlmdZPWSrSzuzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=7/7uowWN2jQeWDxt9eNITvpY2HZF5mcPTVHvPG/MbMQ=; b=pxJXnCP0/77H1V0tMEcOj67O/D6SUvOZVA5xu+LR94jX7ETcTgY4+k2FHJYwkxw6oo xFHn8rKe1G+VSf01aV3W4qQBKwM4DpfFC1rDQyswYB9maxIMmn5yrxPMlQHOcZ4ky+hZ w7SddLmwduIBoiZqTp4DmfdPASlV9HWCWkcJh9fJJizfWoMsS8I2MZtxVhrdKeokbw0f twdR3WmGPlnnTzmUn738GIvEelw0psR3b+fBHEPEYb9XtXeS1lBZyJkGlNo0cr9LG+4h z79IVt4b2TOtDci4Mfl9W3LPzt352YmS3dfUKHgV7vUsGO59VnlFVhoaGiG0h8gLCZLK Xrqg== X-Gm-Message-State: AOAM532z7imdIJk1ooKZ7TPnkXXogChzCEXVdLDS3iaIi+phdY5BzEIq nzY4tyCxh4kdDbWnqUboNHUhQK4XvZsfFyX8azKrMw== X-Google-Smtp-Source: ABdhPJwWfhK1GcpqU0JS0YBVqCjmmL+rUGGuzn4ocxKLaz3l+uhfqZ5RAje9bUKCezb5w0pDB+nkPEk2a5qGGrl4IJM= X-Received: by 2002:a05:6830:44a7:: with SMTP id r39mr22245175otv.25.1628625104215; Tue, 10 Aug 2021 12:51:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 Aug 2021 12:51:43 -0700 MIME-Version: 1.0 In-Reply-To: <1628619089-12502-1-git-send-email-pillair@codeaurora.org> References: <1628619089-12502-1-git-send-email-pillair@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 10 Aug 2021 12:51:43 -0700 Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add WPSS remoteproc node To: Rakesh Pillai , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibis@codeaurora.org, mpubbise@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rakesh Pillai (2021-08-10 11:11:29) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 53a21d0..41a7826 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -74,6 +74,16 @@ > reg = <0 0x8b700000 0 0x10000>; > no-map; > }; > + > + wlan_fw_mem: memory@80c00000 { > + no-map; > + reg = <0x0 0x80c00000 0x0 0xc00000>; > + }; Please try to keep this sorted by reg address. 80c00000 comes before 8b700000. > + > + wpss_mem: memory@9ae00000 { > + no-map; > + reg = <0x0 0x9ae00000 0x0 0x1900000>; > + }; > }; > > cpus { > @@ -1270,6 +1280,53 @@ > }; > }; > > + remoteproc_wpss: remoteproc@8a00000 { > + compatible = "qcom,sc7280-wpss-pil"; > + reg = <0 0x08a00000 0 0x10000>; > + > + interrupts-extended = <&intc GIC_SPI 587 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 0 IRQ_TYPE_NONE>, > + <&wpss_smp2p_in 1 IRQ_TYPE_NONE>, > + <&wpss_smp2p_in 2 IRQ_TYPE_NONE>, > + <&wpss_smp2p_in 3 IRQ_TYPE_NONE>, > + <&wpss_smp2p_in 7 IRQ_TYPE_NONE>; Is this IRQ_TYPE_EDGE_RISING? Please add some type of edge or level flag. > + interrupt-names = "wdog", "fatal", "ready", "handover", > + "stop-ack", "shutdown-ack"; > + > + clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>, > + <&gcc GCC_WPSS_AHB_CLK>, > + <&gcc GCC_WPSS_RSCP_CLK>, > + <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "gcc_wpss_ahb_bdg_mst_clk", > + "gcc_wpss_ahb_clk", > + "gcc_wpss_rscp_clk", > + "xo"; > + > + memory-region = <&wpss_mem>; > + > + qcom,smem-states = <&wpss_smp2p_out 0>;