From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABD0C4338F for ; Tue, 10 Aug 2021 19:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47A3E6056B for ; Tue, 10 Aug 2021 19:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232396AbhHJTSk (ORCPT ); Tue, 10 Aug 2021 15:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhHJTSi (ORCPT ); Tue, 10 Aug 2021 15:18:38 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742D2C0613C1 for ; Tue, 10 Aug 2021 12:18:16 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id r17-20020a0568302371b0290504f3f418fbso295395oth.12 for ; Tue, 10 Aug 2021 12:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=k1IK/wArPuofh/93ioTZO6H7LyceMDQimCWY2mD2ezU=; b=aMODdZG5LqB7gNRAGk32Ef4rqadfXiaWqqB5wNgIvVygGukSPXzPIl+aBksSNVcB4l 72iehfYbtVacuS9r1/kMDqfr5k5oV3eo2H5QIlXmHNg+TYXMYdSFMMDikvuoz69lwBmj TjslM7UhSLrZC7F9E0cdlJeetb59gZRoG73Qk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=k1IK/wArPuofh/93ioTZO6H7LyceMDQimCWY2mD2ezU=; b=C4eg2xNU5hrzed+JIYSa4uN+KER38GnvXkueyniXLxP4vLza60/tZfsdkOA37WTzly jQLn4cS1T5bfM4qjBIN8mOv1AdSs0pAoLq92NNcKHZ1BhK0wpWY25ygp09N0y86WT4ev uITrHnbZMasWl//k9uaRZhLAGApiquB52YZrPM33DUxLmp/Grf8h/uSIBhPojGSHERoI Bi1XvNu5XiQm2ESY6Nbo9pqqCkPjjb6sihFLPXBGD/yOcCzuBeFmSndDGhJkdLYIPMzD 86kc/lkVsMqZ9ROsTmb8WXl7M1geG56Qn/hItpghbLmPwxFeWM0JxyaAiT+cLoZx13Ag US0g== X-Gm-Message-State: AOAM530yUUXC2XSluuV2yreGoY1Z0Mis2IZRse3TSDo5O1WKSCm469ot PV3ennIHcwFcVXNoKYuW9jiZIlwwqyNPze3ntPo35ukUF0o= X-Google-Smtp-Source: ABdhPJyzZrxGALW9iwqei94wy7msgQgsAVIXnt+gxLetD1fNF2MnvVjum7qa8FZVoHBkeTc7UJtw7P9qjZXZ4yRP4kk= X-Received: by 2002:a05:6830:44a7:: with SMTP id r39mr22153068otv.25.1628623094548; Tue, 10 Aug 2021 12:18:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 Aug 2021 12:18:14 -0700 MIME-Version: 1.0 In-Reply-To: <8009f5a1458468dbf0b7b20dd166911c@codeaurora.org> References: <1628180254-758-1-git-send-email-deesin@codeaurora.org> <8009f5a1458468dbf0b7b20dd166911c@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 10 Aug 2021 12:18:13 -0700 Message-ID: Subject: Re: [PATCH V1 1/1] soc: qcom: smp2p: Add wakeup capability to SMP2P IRQ To: Sibi Sankar Cc: Deepak Kumar Singh , bjorn.andersson@linaro.org, clew@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sibi Sankar (2021-08-10 10:24:32) > On 2021-08-09 23:28, Stephen Boyd wrote: > > Quoting Deepak Kumar Singh (2021-08-09 04:05:08) > >> > >> On 8/6/2021 1:10 AM, Stephen Boyd wrote: > >> > Quoting Deepak Kumar Singh (2021-08-05 09:17:33) > >> >> Some use cases require SMP2P interrupts to wake up the host > >> >> from suspend. > >> > Please elaborate on this point so we understand what sort of scenarios > >> > want to wakeup from suspend. > >> > >> Once such scenario is where WiFi/modem crashes and notifies crash to > >> local host through smp2p > >> > >> if local host is in suspend it should wake up to handle the crash and > >> reboot the WiFi/modem. > > > > Does anything go wrong if the firmware crashes during suspend and the > > local host doesn't handle it until it wakes for some other reason? I'd > > like to understand if the crash handling can be delayed/combined with > > another wakeup. > > If the modem firmware crashes > during suspend, the system comes > out of xo-shutdown and AFAIK stays > there until we handle the interrupt. > So you're saying we waste power if we don't wakeup the AP and leave the SoC in a shallow low power state? That would be good to have indicated in the code via a comment and in the commit text so we know that we want to handle the wakeup by default.