From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A6BC432BE for ; Fri, 20 Aug 2021 06:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B81A60F3A for ; Fri, 20 Aug 2021 06:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238574AbhHTGpP (ORCPT ); Fri, 20 Aug 2021 02:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238535AbhHTGpL (ORCPT ); Fri, 20 Aug 2021 02:45:11 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B127C061575 for ; Thu, 19 Aug 2021 23:44:34 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id t35so11914816oiw.9 for ; Thu, 19 Aug 2021 23:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc:content-transfer-encoding; bh=f61uoSIm/tKTfSvriwergj8TTbSumrt6o+1ACHw5Z8o=; b=JAZbuypKzGBgAJ+s2a7SVVACgDfiYPGJPeWiGaW2Z9Y8UtzbDBXPA4CnlTRJaskouX dBY0xaVGfxtWwSvWsKF7kRnan2oWGa3JHlO9DywARJqkEMnm9xVkrWxRHOb/toRlT8il 06JeUuzQPun/WhGSL0A18glSri1g8TVtUQusY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc:content-transfer-encoding; bh=f61uoSIm/tKTfSvriwergj8TTbSumrt6o+1ACHw5Z8o=; b=tEcFkJnv5+utcCW8bnOMA3Az2Tq1KAJDNQmjrHu9UOdEoqEPbuhOEmILVMXQgkyLbO N1mTPPlGxSym5Hk6MEzb5RFdEkrpD6jIIQ2xzkiIHddv7/XWablkgvY1Lq+pVOKMp7yM v+SL/5RSc3M/YnffBUN2GMKtHe1uqqYKPVr5Mbih5SeX8Oa5WciTQmiFpdN/vuyWOS3m C/of8RKAUoGKAg8HyG9crI/CJeCkxb/pm3BNu3ZGSc9ywlBzJ92CffGhW2sLzQx/mQQ1 w5pOJN6QiBO3fXQR3vqoH2+f2tEAe7ec87D4I9E4hE7ppWpdOcxMDufpgssNFyzGoHlX /zAA== X-Gm-Message-State: AOAM531YaRY8Xhua3CgOwTrs03bh9oEBbQLedZn2mAuq5+YY/IYUPvcd Xrzva1SJ4DCTzUQf5RJlkJ94sT+KF11dLjqCyvZdtA== X-Google-Smtp-Source: ABdhPJwl1Sl50w9I94R6TeJfhICfeuXMKa1clo3MNi5WUzWhOgL0bqnI7l6wd9okLAKUi5kPPqMJKK2+hP9OhD2+p7k= X-Received: by 2002:a05:6808:181a:: with SMTP id bh26mr1975912oib.166.1629441873561; Thu, 19 Aug 2021 23:44:33 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Aug 2021 23:44:32 -0700 MIME-Version: 1.0 In-Reply-To: References: <1625576413-12324-1-git-send-email-sanm@codeaurora.org> <1625576413-12324-3-git-send-email-sanm@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 19 Aug 2021 23:44:32 -0700 Message-ID: Subject: Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add USB related nodes To: Andy Gross , Bjorn Andersson , Doug Anderson , Felipe Balbi , Greg Kroah-Hartman , Matthias Kaehlcke , Rob Herring , Sandeep Maheswaram Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sandeep Maheswaram (2021-08-19 22:34:14) > On 8/18/2021 1:28 AM, Stephen Boyd wrote: > > Quoting Sandeep Maheswaram (2021-07-06 06:00:12) > >> Add nodes for DWC3 USB controller, QMP and HS USB PHYs in sc7280 SOC. > >> > >> Signed-off-by: Sandeep Maheswaram > >> Reviewed-by: Matthias Kaehlcke > >> --- > >> Changed qmp usb phy to usb dp phy combo node as per Stephen's comments= . > >> Changed dwc to usb and added SC7280 compatible as per Bjorn's comments= . > >> > >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 164 +++++++++++++++++++++++++= ++++++++++ > >> 1 file changed, 164 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dt= s/qcom/sc7280.dtsi > >> index a8c274a..cd6908f 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> @@ -1035,6 +1035,125 @@ > >> }; > >> }; > >> > > [...] > >> + > >> + usb_2: usb@8cf8800 { > >> + compatible =3D "qcom,sc7280-dwc3", "qcom,dwc3"= ; > >> + reg =3D <0 0x08cf8800 0 0x400>; > >> + status =3D "disabled"; > >> + #address-cells =3D <2>; > >> + #size-cells =3D <2>; > >> + ranges; > >> + dma-ranges; > >> + > >> + clocks =3D <&gcc GCC_CFG_NOC_USB3_SEC_AXI_CLK>= , > >> + <&gcc GCC_USB30_SEC_MASTER_CLK>, > >> + <&gcc GCC_AGGRE_USB3_SEC_AXI_CLK>, > >> + <&gcc GCC_USB30_SEC_MOCK_UTMI_CLK>, > >> + <&gcc GCC_USB30_SEC_SLEEP_CLK>; > >> + clock-names =3D "cfg_noc", "core", "iface","mo= ck_utmi", > >> + "sleep"; > >> + > >> + assigned-clocks =3D <&gcc GCC_USB30_SEC_MOCK_U= TMI_CLK>, > >> + <&gcc GCC_USB30_SEC_MASTER_C= LK>; > >> + assigned-clock-rates =3D <19200000>, <20000000= 0>; > >> + > >> + interrupts-extended =3D <&intc GIC_SPI 240 IRQ= _TYPE_LEVEL_HIGH>, > >> + <&pdc 13 IRQ_TYPE_EDGE_RISING>, > >> + <&pdc 12 IRQ_TYPE_EDGE_RISING>; > > I'm seeing this cause a warning at boot > > > > [ 4.724756] irq: type mismatch, failed to map hwirq-12 for > > interrupt-controller@b220000! > > [ 4.733401] irq: type mismatch, failed to map hwirq-13 for > > interrupt-controller@b220000! > I should be using=C2=A0 IRQ_TYPE_LEVEL_HIGH. Will correct in next version= . Ok. Please send a patch to fix it as this is already staged to be merged in the next merge window.