From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C877CC4332F for ; Thu, 16 Sep 2021 19:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B32B560C40 for ; Thu, 16 Sep 2021 19:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238028AbhIPTIR (ORCPT ); Thu, 16 Sep 2021 15:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347075AbhIPTIC (ORCPT ); Thu, 16 Sep 2021 15:08:02 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3DCC06AA78 for ; Thu, 16 Sep 2021 12:02:37 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id 97-20020a9d006a000000b00545420bff9eso2705064ota.8 for ; Thu, 16 Sep 2021 12:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=FWeWVI89CMKoqS12Pp2ofBTtl9f9+kDvHLEYyvtvj3Y=; b=Wt7OcJpNUxw12DAwblAXr10E60SnW77IXBLxYGtjl4MPd+CK4GnWnRs87pe+Uuu3c8 ohI3BW3y/F/UIenD56eQVQ6KreefgJIrVNqutHJM0rSM4Fb/zmBfCpOGmXur9lqq2EyJ IzKs4ujCFIvkiccoa6fLoYT+/DDXEJgWTUK08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=FWeWVI89CMKoqS12Pp2ofBTtl9f9+kDvHLEYyvtvj3Y=; b=4NKXde9r4eHCTs1wQ2zQmeJlMo4VQB1jvHcI6P0YFQbdD2gHjvNaGsljr2OKILNkZT O/7Qq9A/1WRMAPZ35tUDqYhnrbLekaVaTLN7yyLnKAEyoUM+NIi+IbQVLXWnV5DFa5uc k8JHPJxdbH9sAdDYntruUfAuTLJ86Q3BWbJbvwwbF2TuGMtoVi3ZgbHzu3keWLb9ShE1 g/woJB/7zMjWJLb5EaxgaLPmaylV7wlrXfwMEq7snWkeehyQ3lbvZGGesTK8VfwyEkzq k7MX4twkTY76DgRVa7bj32JBpnniNoMi09StjTWGncvjL8cb/WTCSD5Rs0AxIptQiu2+ mU5A== X-Gm-Message-State: AOAM530H2vsr6YYehjMH7F7JBLGyQ3SrXyIJhbqpYjYzIF0ShRrZ1ZUc EhJIfJGn8bINialQTP+/1s/iSIBA/9xhhfifMHJsEg== X-Google-Smtp-Source: ABdhPJzEFLzP9i6NLH2BNZiamfhPoIiZWSUb5DRAGv784Z0t+KDMcv3d9XBq8O+KgpL10r2bUObyqJ+JYSPOsod0imQ= X-Received: by 2002:a05:6830:1212:: with SMTP id r18mr5777608otp.159.1631818956932; Thu, 16 Sep 2021 12:02:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 12:02:36 -0700 MIME-Version: 1.0 In-Reply-To: <1631798498-10864-3-git-send-email-skakit@codeaurora.org> References: <1631798498-10864-1-git-send-email-skakit@codeaurora.org> <1631798498-10864-3-git-send-email-skakit@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 16 Sep 2021 12:02:36 -0700 Message-ID: Subject: Re: [PATCH V5 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp To: Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Satya Priya Cc: David Collins , kgunda@codeaurora.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Satya Priya (2021-09-16 06:21:38) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 371a2a9..cbbb0ee 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -12,6 +12,26 @@ > #include "pm8350c.dtsi" > #include "pmk8350.dtsi" > > +/ { > + gpio-keys { > + compatible = "gpio-keys"; > + label = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&key_vol_up_default>; > + > + volume-up { > + label = "volume_up"; > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > + linux,input-type = <1>; > + linux,code = ; Is there an include for this define? Looks like should be added as well? Did you try compiling? > + gpio-key,wakeup; > + debounce-interval = <15>; > + linux,can-disable; > + }; > + }; > +}; > + > &apps_rsc { > pm7325-regulators { > compatible = "qcom,pm7325-rpmh-regulators"; > @@ -284,6 +304,17 @@ > > /* PINCTRL - additions to nodes defined in sc7280.dtsi */ > > +&pm7325_gpios { > + key_vol_up_default: key-vol-up-default { > + pins = "gpio6"; > + function = "normal"; > + input-enable; > + bias-pull-up; > + power-source = <0>; > + qcom,drive-strength = <3>; > + }; > +}; > + > &qup_uart5_default { > tx { > pins = "gpio46"; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >