From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D52C4338F for ; Thu, 22 Jul 2021 19:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E47C160EB5 for ; Thu, 22 Jul 2021 19:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhGVSoK (ORCPT ); Thu, 22 Jul 2021 14:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbhGVSoI (ORCPT ); Thu, 22 Jul 2021 14:44:08 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF2D2C061575 for ; Thu, 22 Jul 2021 12:24:41 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id f12-20020a056830204cb029048bcf4c6bd9so6321827otp.8 for ; Thu, 22 Jul 2021 12:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=KuoKHa70CsW4LrT7bcKs/jVjMpHneRrtGiMYYCoaWt4=; b=ODDEI+V9cWtMOLMoDoSf/Eso7AyIQN1IrQyHsmjBNLMM67HXTrSmNTGcMfzlvfF04I Xl0GxDCskVr2bMK95Z5NurgL24fO4chAe5Vd74Qwg5YeOWpxXdiu1++dzqNL26zur3JO bWJsxhH6u+8e4EaELYsJDemAduUlBjkWkzrl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=KuoKHa70CsW4LrT7bcKs/jVjMpHneRrtGiMYYCoaWt4=; b=IP8JO4rdtCy6jukavgOhX/mDfwgbuezJ/wOdkHt2dFjRW2vwJa83kvnsc7vLlxtVJN 2BcGzBwI78XKhkk3n2/CEXmCqA4c9MIlCdkjUlhJkzmMFtUAnFBJcfhcy9m5XhSUb1r6 KszwsCqeBWtq+TUBLWvJD6mJXel9A6+bSxLEzhREF3litLJ5ZjUdBYCDhPVffNag+hxv rF7Vz6xuu6Pyrtglm90xvvAQCJnR0eNvanPlte+6IFVHkOadLJaC1QhM3oeHkq0OpqWh 5gDyGSenpRJLKR5tTWQg4MZLHdW8vj42r1393OMZJ+FqnRrH5B4AslRi2ObUOWHzkw4F 0VYg== X-Gm-Message-State: AOAM533yXut0RQ73ouBhn6bV/k82J46OWNAK3xBJoYEdRTZFConrupkE 34SWABtdzfLBYytRoftDpsiVoXjze6trbEFrBxg2Gg== X-Google-Smtp-Source: ABdhPJxhpg6Vf9SRJDcvLibbgnzzwZMBFdPr2+2+u0dMH/k8tpteCCY8x1EBDEKXikNagWxWYufbywGdcpp1es+qvug= X-Received: by 2002:a9d:1b6e:: with SMTP id l101mr896344otl.34.1626981881398; Thu, 22 Jul 2021 12:24:41 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 19:24:40 +0000 MIME-Version: 1.0 In-Reply-To: <1626191647-13901-5-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-5-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 19:24:40 +0000 Message-ID: Subject: Re: [PATCH v2 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kuogee Hsieh (2021-07-13 08:54:04) > Remove special handling of replug interrupt and instead treat replug event > as a sequential unplug followed by a plugin event. This is needed to meet > the requirements of DP Link Layer CTS test case 4.2.1.3. > > Changes in V2: > -- add fixes statement > > Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly") > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 78c5301..d089ada 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1146,9 +1146,6 @@ static int hpd_event_thread(void *data) > case EV_IRQ_HPD_INT: > dp_irq_hpd_handle(dp_priv, todo->data); > break; > - case EV_HPD_REPLUG_INT: Please remove the enum as well. > - /* do nothing */ > - break; > case EV_USER_NOTIFICATION: > dp_display_send_hpd_notification(dp_priv, > todo->data);