From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC89C432BE for ; Thu, 26 Aug 2021 07:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 618E5610A7 for ; Thu, 26 Aug 2021 07:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240176AbhHZHoH (ORCPT ); Thu, 26 Aug 2021 03:44:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240113AbhHZHoE (ORCPT ); Thu, 26 Aug 2021 03:44:04 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38496C0613CF for ; Thu, 26 Aug 2021 00:43:13 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id w19so3281767oik.10 for ; Thu, 26 Aug 2021 00:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=LEECzjw9cAEfzX4h9vkbRwWXNoxUMF+O32+9m96eguo=; b=iWJt3xiTwRlWDaxE/vdGSwl89PVd5QpSpCA9MGyYLGMM9tLlH8gFtyC7T1rKacZGGn Ejnl1HqQWQMuTUTDascCNn7wR5qkbCDLcww1J0O6UhN6ln6QzKRDtLQLKYZ9+EeqDfhL EG4UgIGmhaFXfhiiN6ojNTuLrCPnwoNsTcQOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=LEECzjw9cAEfzX4h9vkbRwWXNoxUMF+O32+9m96eguo=; b=rLiKpaykw7/h2Dx0w/lNEX6XD8Z95qqnNESJ3GWTlT1UWoekqjra70qFnXONQa8NcK L9PJJ9BDD6be3tpe9djnqkkfJ+S8rkZT0/mwVb1E+IkIJIpzh8TrjGAAlhMh6TT9FlmP In2PLGgShHat49K+26pLr2JsUtWi6HXOiCX9+l+OhkEH+LNcBUMr2boHoxd8wLW2saWZ RjEvLVcqN2MceNg499RkjtRXUCHBHMsgmX0qOLG7/8hfbuM2bbNHnuT8kt5aXJaWqmBB l9Ms/X0KLzvkTfX65pG0U2NZojdrRAeh8KEKH5pbd8Dk4ltegoQD539kJFFKoFWIr+Mt j2UQ== X-Gm-Message-State: AOAM532NL7rT8y/dFNXKraFhitlU8AXyzVCzHhW6MoVUNL4yNe9WRIof p9Tvb1ICvQO6DSNid8lQIh8ye8jWO8ajiLH5UdwHbw== X-Google-Smtp-Source: ABdhPJw6LeRszszYvlKT8BPrwfjzgPVcCpjequieRxS7/W04iTvrhITxDPd/lv7OUWv+AtbMDaSEl2H9lkGW+RMcH9Y= X-Received: by 2002:a05:6808:180e:: with SMTP id bh14mr1464661oib.19.1629963792627; Thu, 26 Aug 2021 00:43:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Aug 2021 07:43:11 +0000 MIME-Version: 1.0 In-Reply-To: References: <1626435974-14462-1-git-send-email-sbhanu@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 26 Aug 2021 07:43:11 +0000 Message-ID: Subject: Re: [PATCH V4] mmc: sdhci-msm: Update the software timeout value for sdhc To: Shaik Sajida Bhanu , Ulf Hansson Cc: Adrian Hunter , Asutosh Das , Sahitya Tummala , Veerabhadrarao Badiganti , Ram Prakash Gupta , Sayali Lokhande , Sarthak Garg , Rajendra Nayak , cang@codeaurora.org, Pradeep P V K , nitirawa@codeaurora.org, linux-mmc , Linux Kernel Mailing List , linux-arm-msm , Andy Gross , Bjorn Andersson , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ulf Hansson (2021-08-04 04:34:52) > + Stephen > > On Mon, 2 Aug 2021 at 12:41, wrote: > > > > Gentle Reminder > > > > Thanks, > > Sajida > > > > On 2021-07-16 17:16, Shaik Sajida Bhanu wrote: > > > Whenever SDHC run at clock rate 50MHZ or below, the hardware data > > > timeout value will be 21.47secs, which is approx. 22secs and we have > > > a current software timeout value as 10secs. We have to set software > > > timeout value more than the hardware data timeout value to avioid > > > seeing > > > the below register dumps. > > > > > > [ 332.953670] mmc2: Timeout waiting for hardware interrupt. > > > [ 332.959608] mmc2: sdhci: ============ SDHCI REGISTER DUMP > > > =========== > > > [ 332.966450] mmc2: sdhci: Sys addr: 0x00000000 | Version: > > > 0x00007202 > > > [ 332.973256] mmc2: sdhci: Blk size: 0x00000200 | Blk cnt: > > > 0x00000001 > > > [ 332.980054] mmc2: sdhci: Argument: 0x00000000 | Trn mode: > > > 0x00000027 > > > [ 332.986864] mmc2: sdhci: Present: 0x01f801f6 | Host ctl: > > > 0x0000001f > > > [ 332.993671] mmc2: sdhci: Power: 0x00000001 | Blk gap: > > > 0x00000000 > > > [ 333.000583] mmc2: sdhci: Wake-up: 0x00000000 | Clock: > > > 0x00000007 > > > [ 333.007386] mmc2: sdhci: Timeout: 0x0000000e | Int stat: > > > 0x00000000 > > > [ 333.014182] mmc2: sdhci: Int enab: 0x03ff100b | Sig enab: > > > 0x03ff100b > > > [ 333.020976] mmc2: sdhci: ACmd stat: 0x00000000 | Slot int: > > > 0x00000000 > > > [ 333.027771] mmc2: sdhci: Caps: 0x322dc8b2 | Caps_1: > > > 0x0000808f > > > [ 333.034561] mmc2: sdhci: Cmd: 0x0000183a | Max curr: > > > 0x00000000 > > > [ 333.041359] mmc2: sdhci: Resp[0]: 0x00000900 | Resp[1]: > > > 0x00000000 > > > [ 333.048157] mmc2: sdhci: Resp[2]: 0x00000000 | Resp[3]: > > > 0x00000000 > > > [ 333.054945] mmc2: sdhci: Host ctl2: 0x00000000 > > > [ 333.059657] mmc2: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: > > > 0x0000000ffffff218 > > > [ 333.067178] mmc2: sdhci_msm: ----------- VENDOR REGISTER DUMP > > > ----------- > > > [ 333.074343] mmc2: sdhci_msm: DLL sts: 0x00000000 | DLL cfg: > > > 0x6000642c | DLL cfg2: 0x0020a000 > > > [ 333.083417] mmc2: sdhci_msm: DLL cfg3: 0x00000000 | DLL usr ctl: > > > 0x00000000 | DDR cfg: 0x80040873 > > > [ 333.092850] mmc2: sdhci_msm: Vndr func: 0x00008a9c | Vndr func2 : > > > 0xf88218a8 Vndr func3: 0x02626040 > > > [ 333.102371] mmc2: sdhci: > > > ============================================ > > > > > > So, set software timeout value more than hardware timeout value. > > > > > > Signed-off-by: Shaik Sajida Bhanu > > > Acked-by: Adrian Hunter > > Applied for fixes and by adding a stable tag, thanks! > Thanks. Looks like none of the stable trees could apply it though :(