From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbbCLIQn (ORCPT ); Thu, 12 Mar 2015 04:16:43 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:43298 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbbCLIQi (ORCPT ); Thu, 12 Mar 2015 04:16:38 -0400 MIME-Version: 1.0 In-Reply-To: <1426091777-30592-1-git-send-email-daniel.baluta@intel.com> References: <1426091777-30592-1-git-send-email-daniel.baluta@intel.com> Date: Thu, 12 Mar 2015 10:16:37 +0200 Message-ID: Subject: Re: [PATCH] staging: iio: trigger: Use standard attr for sampling frequency From: Octavian Purdila To: Daniel Baluta Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 6:36 PM, Daniel Baluta wrote: > > As written in Documentation/ABI/testing/sysfs-bus-iio the trigger > attribute for sampling frequency should be sampling_frequency. > > Fix this for iio-trig-periodic-rtc module in order to prepare it > for moving out of staging. > > Signed-off-by: Daniel Baluta > --- > Jonathan, this module is very useful for devices that do not have > an interrupt pin. > > We are working on drivers for such devices and would be very nice to > move this driver in advance to the IIO non-staging location. > > What do you say? > Hmm, I wonder what are the advantages of using RTC timers. Couldn't we use a regular kernel timer instead? > drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > index 89df1d3..f1cfe2d 100644 > --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > @@ -87,12 +87,12 @@ error_ret: > return ret; > } > > -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, > +static DEVICE_ATTR(sampling_frequency, S_IRUGO | S_IWUSR, > iio_trig_periodic_read_freq, > iio_trig_periodic_write_freq); > > static struct attribute *iio_trig_prtc_attrs[] = { > - &dev_attr_frequency.attr, > + &dev_attr_sampling_frequency.attr, > NULL, > }; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html