From: Andrew Duggan <andrew.duggan@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Benson Leung <bleung@chromium.org>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Add hid-over-i2c name to i2c id table
Date: Wed, 9 Mar 2016 10:37:51 -0800 [thread overview]
Message-ID: <CAE7eX3LswXqKRP6yM9ggZR9dy6vby1KST3uCJm7SFDqyx5i_6Q@mail.gmail.com> (raw)
In-Reply-To: <20160308192539.GA23955@dtor-ws>
On Tue, Mar 8, 2016 at 11:25 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> When using the device tree binding OF compatible = "hid-over-i2c" the
> i2c id table also needs to have that name in order to auto load this
> driver, since i2c core reports module alias as i2c:<string> where
> <string> is compatible string of OF binding stripped of manufacturer's
> prefix.
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Tested-by: Andrew Duggan <aduggan@synaptics.com>
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index b921693..a2c6c98 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1191,6 +1191,7 @@ static const struct dev_pm_ops i2c_hid_pm = {
>
> static const struct i2c_device_id i2c_hid_id_table[] = {
> { "hid", 0 },
> + { "hid-over-i2c", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
> --
> 2.7.0.rc3.207.g0ac5344
>
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-09 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 19:25 [PATCH] HID: i2c-hid: Add hid-over-i2c name to i2c id table Dmitry Torokhov
2016-03-09 18:37 ` Andrew Duggan [this message]
2016-03-09 19:50 ` Benjamin Tissoires
2016-03-09 20:50 ` Jiri Kosina
2016-03-10 0:15 ` Dmitry Torokhov
2016-03-10 9:05 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2014-10-14 21:44 Benson Leung
2014-10-14 22:59 ` Dmitry Torokhov
2014-10-23 18:45 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE7eX3LswXqKRP6yM9ggZR9dy6vby1KST3uCJm7SFDqyx5i_6Q@mail.gmail.com \
--to=andrew.duggan@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).