From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbbDDA6H (ORCPT ); Fri, 3 Apr 2015 20:58:07 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:35316 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbDDA6D (ORCPT ); Fri, 3 Apr 2015 20:58:03 -0400 MIME-Version: 1.0 In-Reply-To: <551EDB92.9070008@hurleysoftware.com> References: <1425932842-21812-1-git-send-email-peter@hurleysoftware.com> <1425932842-21812-12-git-send-email-peter@hurleysoftware.com> <551CB5DF.1010108@hurleysoftware.com> <551D6EEA.6050704@hurleysoftware.com> <551E6D61.7000501@hurleysoftware.com> <551ED011.1030004@hurleysoftware.com> <551EDB92.9070008@hurleysoftware.com> Date: Fri, 3 Apr 2015 17:58:03 -0700 X-Google-Sender-Auth: qBXynVPEd-SWKpPSjAVlSm8bJeg Message-ID: Subject: Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console() From: Yinghai Lu To: Peter Hurley Cc: Andrew Morton , Greg Kroah-Hartman , Linux Kernel Mailing List , Jiri Slaby , Rob Herring , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley wrote: > On 04/03/2015 01:44 PM, Yinghai Lu wrote: > > which means you have to have CONFIG_SERIAL_EARLYCON to get a serial console > at all. what do you mean? Now in drivers/tty/serial/8250/Kconfig we have config SERIAL_8250_CONSOLE bool "Console on 8250/16550 and compatible serial port" depends on SERIAL_8250=y select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON do you mean, we should not have that "select SERIAL_EARLYCON" ?