From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Renninger <trenn@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>,
Takao Indoh <indou.takao@jp.fujitsu.com>,
linux-pci@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, andi@firstfloor.org,
tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org,
hbabu@us.ibm.com, mingo@redhat.com, ddutile@redhat.com,
vgoyal@redhat.com, ishii.hironobu@jp.fujitsu.com,
bhelgaas@google.com, tglx@linutronix.de, khalid@gonehiking.org,
horms@verge.net.au
Subject: Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case
Date: Mon, 14 Jan 2013 20:45:43 -0800 [thread overview]
Message-ID: <CAE9FiQUgqRLO4O4HFBC_D5o8TQhnouEaDNq82wdwuu57=OsoZQ@mail.gmail.com> (raw)
In-Reply-To: <1824463.EWDqkMLC4N@hammer82.arch.suse.de>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On Mon, Jan 14, 2013 at 4:54 PM, Thomas Renninger <trenn@suse.de> wrote:
> On Monday, January 14, 2013 11:04:36 AM Yinghai Lu wrote:
>> On Mon, Jan 14, 2013 at 7:05 AM, Thomas Renninger <trenn@suse.de> wrote:
>> > What is this for?:
>> > @@ -871,6 +879,11 @@ static int __init parse_memmap_one(char
>> >
>> > userdef = 1;
>> > if (*p == '@') {
>> >
>> > start_at = memparse(p+1, &p);
>> >
>> > + if (exactusablemap_parsed) {
>> > + /* remove all range with other types */
>> > + e820_remove_range(start_at, mem_size,
>> > + E820_RAM, 0);
>> > + }
>> >
>> > e820_add_region(start_at, mem_size, E820_RAM);
>> >
>> > } else if (*p == '#') {
>> >
>> > start_at = memparse(p+1, &p);
>>
>> remove all old renges before add E820_RAM, otherwise new add E820
>> ranges could be ignored.
> But this is intended?
> kexec must never request reserved memory to be used as ordinary E820_RAM
> by the kdump kernel.
> This also reverts what exactusablemap is all about:
> Keep all reserved memory ranges of the original BIOS map.
>
> Above would again wrongly remove the mmconf and other reserved regions
> if kexec passes memmap=exactuseablemap,x@y
>
> From what I can see the patch looks fine, but above part should
> simply be left out.
then, I would like to rename it to resetusablemap instead.
like attached.
Thanks
Yinghai
[-- Attachment #2: e820_resetusablemap.patch --]
[-- Type: application/octet-stream, Size: 1161 bytes --]
---
arch/x86/kernel/e820.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/x86/kernel/e820.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/e820.c
+++ linux-2.6/arch/x86/kernel/e820.c
@@ -845,7 +845,7 @@ static int __init parse_memmap_one(char
if (!p)
return -EINVAL;
- if (!strncmp(p, "exactmap", 8)) {
+ if (!strncmp(p, "exactmap", 8) || !strncmp(p, "resetusablemap", 14)) {
if (exactmap_parsed)
return 0;
@@ -858,7 +858,11 @@ static int __init parse_memmap_one(char
*/
saved_max_pfn = e820_end_of_ram_pfn();
#endif
- e820.nr_map = 0;
+ if (!strncmp(p, "resetusablemap", 14)) {
+ /* remove all old E820_RAM ranges */
+ e820_remove_range(0, ULLONG_MAX, E820_RAM, 1);
+ } else
+ e820.nr_map = 0;
userdef = 1;
return 0;
}
@@ -890,6 +894,11 @@ static int __init parse_memmap_opt(char
p = strstr(p, "exactmap");
if (p)
parse_memmap_one("exactmap");
+ else {
+ p = strstr(boot_command_line, "resetusablemap");
+ if (p)
+ parse_memmap_one("resetusablemap");
+ }
while (str) {
char *k = strchr(str, ',');
next prev parent reply other threads:[~2013-01-15 4:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 0:42 [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh
2012-11-27 0:42 ` [PATCH v7 1/5] x86, pci: add dummy pci device for early stage Takao Indoh
2012-11-27 0:42 ` [PATCH v7 2/5] PCI: Define the maximum number of PCI function Takao Indoh
2012-11-27 0:42 ` [PATCH v7 3/5] Make reset_devices available at early stage Takao Indoh
2012-11-27 0:43 ` [PATCH v7 4/5] x86, pci: Reset PCIe devices at boot time Takao Indoh
2012-11-27 0:43 ` [PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled Takao Indoh
2012-11-30 15:49 ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu MUNEDA Takahiro
2012-12-21 16:19 ` Yinghai Lu
2013-01-07 19:09 ` Thomas Renninger
2013-01-07 20:16 ` Yinghai Lu
2013-01-08 0:42 ` Thomas Renninger
2013-01-08 3:04 ` Yinghai Lu
2013-01-08 16:47 ` [PATCH] Only reset e820 once, even with multiple memmap=exactmap params Thomas Renninger
2013-01-08 17:19 ` Yinghai Lu
2013-01-10 3:21 ` Thomas Renninger
2013-01-10 14:26 ` Vivek Goyal
2013-01-10 16:53 ` Yinghai Lu
2013-01-10 17:01 ` Vivek Goyal
2013-01-10 17:11 ` Yinghai Lu
2013-01-10 23:34 ` Yinghai Lu
2013-01-11 12:33 ` [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case Thomas Renninger
2013-01-11 16:16 ` Yinghai Lu
2013-01-11 18:24 ` Thomas Renninger
2013-01-11 19:59 ` Yinghai Lu
2013-01-11 20:06 ` H. Peter Anvin
2013-01-11 21:09 ` Yinghai Lu
2013-01-11 22:16 ` H. Peter Anvin
2013-01-12 11:31 ` Thomas Renninger
2013-01-12 17:07 ` Yinghai Lu
2013-01-14 2:08 ` Thomas Renninger
2013-01-14 2:43 ` Yinghai Lu
2013-01-14 15:05 ` Thomas Renninger
2013-01-14 19:04 ` Yinghai Lu
2013-01-15 0:54 ` Thomas Renninger
2013-01-15 4:45 ` Yinghai Lu [this message]
2013-01-22 15:21 ` Thomas Renninger
2013-01-08 16:50 ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Thomas Renninger
2013-01-08 17:27 ` Yinghai Lu
2013-01-09 2:32 ` Thomas Renninger
2013-01-09 4:39 ` Takao Indoh
2013-01-21 1:11 ` Takao Indoh
2013-01-23 0:47 ` Thomas Renninger
2013-01-24 0:23 ` Takao Indoh
2013-01-29 1:14 ` Thomas Renninger
2013-01-30 5:01 ` Takao Indoh
2013-03-04 0:56 ` Takao Indoh
2013-03-04 22:00 ` Don Dutile
2013-03-05 0:56 ` Takao Indoh
[not found] ` <CAK4g67ZEUfCqqpa1-4wkN4+OXZYQqLTiJC+6OpwVWVLfO2_7xQ@mail.gmail.com>
2012-12-21 10:37 ` Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE9FiQUgqRLO4O4HFBC_D5o8TQhnouEaDNq82wdwuu57=OsoZQ@mail.gmail.com' \
--to=yinghai@kernel.org \
--cc=andi@firstfloor.org \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=muneda.takahiro@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tokunaga.keiich@jp.fujitsu.com \
--cc=trenn@suse.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).