From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbbDDAxD (ORCPT ); Fri, 3 Apr 2015 20:53:03 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:36436 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbDDAw7 (ORCPT ); Fri, 3 Apr 2015 20:52:59 -0400 MIME-Version: 1.0 In-Reply-To: <551EDB92.9070008@hurleysoftware.com> References: <1425932842-21812-1-git-send-email-peter@hurleysoftware.com> <1425932842-21812-12-git-send-email-peter@hurleysoftware.com> <551CB5DF.1010108@hurleysoftware.com> <551D6EEA.6050704@hurleysoftware.com> <551E6D61.7000501@hurleysoftware.com> <551ED011.1030004@hurleysoftware.com> <551EDB92.9070008@hurleysoftware.com> Date: Fri, 3 Apr 2015 17:52:58 -0700 X-Google-Sender-Auth: jPaRJfRm-M52NZk5-SQ5iMfd87M Message-ID: Subject: Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console() From: Yinghai Lu To: Peter Hurley Cc: Andrew Morton , Greg Kroah-Hartman , Linux Kernel Mailing List , Jiri Slaby , Rob Herring , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley wrote: > On 04/03/2015 01:44 PM, Yinghai Lu wrote: >> On Fri, Apr 3, 2015 at 10:38 AM, Peter Hurley wrote: >>> On 04/03/2015 12:57 PM, Yinghai Lu wrote: >>> >>> Wait -- you have earlycon in a product?? >> >> What do you mean? > > I mean, what will happen if I put in a big debug banner like Steven > did for ftrace? > > Kernel developers need earlycon for debugging arch code; often the earlycon > is just hacked together especially when it requires fixmap support. > > Putting it in a product and _relying on undocumented behavior_ is a bad idea. let me repeat again: when you have "console=uart8250,io,0x3f8", you will have earlycon and then console. That is just for kernel developer for debugging. When you have x86 with bunch of dimms and cpus, user will have to wait couple of minutes to output from console=ttyS0....and if it hang early, no one would know what happen. Also it is only boot time only....