On Sun, Sep 2, 2012 at 11:26 PM, Pekka Enberg wrote: > > Yup, or move the globals together with the comment to arch/x86/mm/init.c. > > That said, max_pfn_high_mapped really ought to be kept together with > the other "pfn_mapped" globals and the comment should be updated. max_pfn_high_mapped is only for 64bit, and it is in init_64.c maybe later could have another patch to move max_pfn_mapped, max_low_pfn_mapped from kernel/setup.c to mm/init.c Please check attached updated patch. Thanks Yinghai