From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbbCJT35 (ORCPT ); Tue, 10 Mar 2015 15:29:57 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:46004 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbbCJT3v (ORCPT ); Tue, 10 Mar 2015 15:29:51 -0400 MIME-Version: 1.0 In-Reply-To: <20150310154828.GJ3535@pd.tnic> References: <1425766041-6551-1-git-send-email-yinghai@kernel.org> <1425766041-6551-4-git-send-email-yinghai@kernel.org> <20150310093430.GC3535@pd.tnic> <20150310151035.GG3535@pd.tnic> <20150310152137.GI3535@pd.tnic> <20150310154828.GJ3535@pd.tnic> Date: Tue, 10 Mar 2015 12:29:50 -0700 X-Google-Sender-Auth: JGr5z7TsdCan0GhuOxK-egVVGGE Message-ID: Subject: Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data From: Yinghai Lu To: Borislav Petkov , "H. Peter Anvin" , Ingo Molnar Cc: Matt Fleming , Kees Cook , Baoquan He , Thomas Gleixner , Jiri Kosina , Linux Kernel Mailing List , "linux-efi@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: >> In arch/x86/boot/header.S, we already use VO and ZO. >> So please keep on using them, and don't introduce "kernel proper" etc. > > So you're suggesting commit messages should use variable names and > prefixes from the code instead of being human-readable? Now we have vmlinux ===> VO or kernel, that is output/init_size in misc.c arch/x86/boot/compressed/vmlinux.bin.xz ==> compressed kernel. that is input/input_len in misc.c arch/x86/boot/compressed/vmllinux ==> ZO, arch/x86/boot/setup + ZO is bzImage. I really think we should not use "compressed kernel" for arch/x86/boot/compressed/vmlinux that should stand for compressed vmlinux. VO/ZO should be better thatn "kernel proper"/'compressed kernel" for vmlinux/"arch/x86/boot/compressed/vmlinux" ? Peter/Ingo, How to you think about that? Thanks Yinghai