From: Evan Green <evgreen@chromium.org>
To: sayalil@codeaurora.org
Cc: subhashj@codeaurora.org, cang@codeaurora.org,
vivek.gautam@codeaurora.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
asutoshd@codeaurora.org, riteshh@codeaurora.org,
adrian.hunter@intel.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 2/2] scsi: ufs: Add configfs support for UFS provisioning
Date: Mon, 6 Aug 2018 09:40:18 -0700 [thread overview]
Message-ID: <CAE=gft46yHTxG5rpBLJ-x5AiETaGGdnsnEHjzSx2BsG4=sUKHA@mail.gmail.com> (raw)
In-Reply-To: <1533113338-31750-3-git-send-email-sayalil@codeaurora.org>
Hi Sayali,
On Wed, Aug 1, 2018 at 1:49 AM Sayali Lokhande <sayalil@codeaurora.org> wrote:
>
> This patch adds configfs support to provision UFS device at
> runtime. This feature can be primarily useful in factory or
> assembly line as some devices may be required to be configured
> multiple times during initial system development phase.
> Configuration Descriptors can be written multiple times until
> bConfigDescrLock attribute is zero.
>
> Configuration descriptor buffer consists of Device and Unit
> descriptor configurable parameters which are parsed from vendor
> specific provisioning file and then passed via configfs node at
> runtime to provision ufs device.
> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>
> Usage:
> 1) To read current configuration descriptor :
> cat /config/XXXX.ufshc/ufs_provision
> 2) To provision ufs device:
> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>
> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
> ---
> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
> drivers/scsi/ufs/Kconfig | 10 ++
> drivers/scsi/ufs/Makefile | 1 +
> drivers/scsi/ufs/ufs-configfs.c | 162 ++++++++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.c | 7 +-
> drivers/scsi/ufs/ufshcd.h | 10 ++
> 6 files changed, 207 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>
You didn't address any of my feedback from V6. All of that still applies.
-Evan
prev parent reply other threads:[~2018-08-06 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1533113338-31750-1-git-send-email-sayalil@codeaurora.org>
2018-08-01 8:48 ` [PATCH V7 1/2] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-08-06 17:26 ` Evan Green
2018-08-09 8:50 ` Sayali Lokhande
2018-08-01 8:48 ` [PATCH V7 2/2] scsi: ufs: Add configfs support for UFS provisioning Sayali Lokhande
2018-08-06 16:40 ` Evan Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft46yHTxG5rpBLJ-x5AiETaGGdnsnEHjzSx2BsG4=sUKHA@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=riteshh@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).