From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE1BC4363A for ; Thu, 29 Oct 2020 00:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00DC5207DE for ; Thu, 29 Oct 2020 00:30:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dVbiFvDr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388527AbgJ2A34 (ORCPT ); Wed, 28 Oct 2020 20:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728106AbgJ2A3p (ORCPT ); Wed, 28 Oct 2020 20:29:45 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6821FC0613CF for ; Wed, 28 Oct 2020 17:29:45 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id r127so1064868lff.12 for ; Wed, 28 Oct 2020 17:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7jNAEm6Hi0csIlAhJak64h6CkXzGG/PjJ55O7rc69w0=; b=dVbiFvDr5hJzG53SMPD8precPJBr4LhbfNdzfOWJKKosCPkE3U8Ech812UHrucQHfv E6ottCjFlpuwTsu3cvPVUcLBNhLxknUL9qAC1EQEH5lFYv0YOqmeBBkai/fZm68Y1uGJ OHmPM76qoxHM+OiAeFY4lENZ6ebZWLhWm47PA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7jNAEm6Hi0csIlAhJak64h6CkXzGG/PjJ55O7rc69w0=; b=ueRXNG1NcgCetwu6jOstSlIf2VIPjAHDd7KAwTkQ7O2+JH/O5qt/4e0VJWGq4PCsHQ TRwh2qqK3MmKQpEXpa0lFQMFh/oWWUw8EXY4ic6sOnztn8aPHew9YTzxFqwNRxpW5pXu gJq/lPVQ6FK9PDk9rlXy06+JAEEmPhJcbcw5peI/esh1SMCQ3OJOCE5xPxMUyA3XoILS SUjcmAjScmQT41VZq/ttB8xSvDeX1gb59BaTxGhtGzoXNMHC2O/mmVGFaw+oGptBmUqi 2ANseQFY/LaKf/NQB9XEYcaAxE4bYDfg37axMrFLOLuBkeyr9nqRtGdy1jcycfWAIy4X BvDA== X-Gm-Message-State: AOAM530ye5nuRO0ydz6n4co81sa0bMhVMkkN4EQOI08SfUMMaLdaoJqB D1FFyFysPmW9YBc4Fesm2BvB80KHOnV1DQ== X-Google-Smtp-Source: ABdhPJwej/LcmCdCKWiEqFJ1F4ZhABLVyvjNxjpObmt6SbE4cs55MQVGp3ATxbmdNaLmTJKC1ezOjg== X-Received: by 2002:ac2:4244:: with SMTP id m4mr539980lfl.562.1603931383703; Wed, 28 Oct 2020 17:29:43 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id m13sm105466lfl.269.2020.10.28.17.29.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 17:29:43 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id v6so1056302lfa.13 for ; Wed, 28 Oct 2020 17:29:42 -0700 (PDT) X-Received: by 2002:a19:6b0d:: with SMTP id d13mr519613lfa.485.1603931382411; Wed, 28 Oct 2020 17:29:42 -0700 (PDT) MIME-Version: 1.0 References: <20201016192654.32610-1-evgreen@chromium.org> <20201016122559.v2.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid> In-Reply-To: From: Evan Green Date: Wed, 28 Oct 2020 17:29:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: nvmem: Add soc qfprom compatible strings To: Doug Anderson Cc: Rob Herring , Bjorn Andersson , Srinivas Kandagatla , Stephen Boyd , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 2:41 PM Doug Anderson wrote: > > Hi, > > On Fri, Oct 16, 2020 at 12:27 PM Evan Green wrote: > > > > Add SoC-specific compatible strings so that data can be attached > > to it in the driver. > > > > Signed-off-by: Evan Green > > --- > > > > Changes in v2: > > - Add other soc compatible strings (Doug) > > - Fix compatible string definition (Doug) > > > > .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > index 1a18b6bab35e7..eb1440045aff1 100644 > > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > @@ -14,7 +14,18 @@ allOf: > > > > properties: > > compatible: > > - const: qcom,qfprom > > + items: > > + - enum: > > + - qcom,apq8064-qfprom > > + - qcom,apq8084-qfprom > > + - qcom,msm8974-qfprom > > + - qcom,msm8916-qfprom > > + - qcom,msm8996-qfprom > > + - qcom,msm8998-qfprom > > + - qcom,qcs404-qfprom > > + - qcom,sc7180-qfprom > > + - qcom,sdm845-qfprom > > + - const: qcom,qfprom > > > > reg: > > # If the QFPROM is read-only OS image then only the corrected region > > As Rob's bot found, your example no longer matches your requirements. > It needs an SoC-specific string plus the "qcom,qfprom". It's always > good to try running "make dt_binding_check" to catch these sorts of > things. Thanks Doug, will do for the next spin! -Evan