From: Evan Green <evgreen@chromium.org>
To: axboe@kernel.dk
Cc: Gwendal Grignou <gwendal@chromium.org>,
asavery@chromium.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] loop: Better discard support for block devices
Date: Mon, 26 Nov 2018 10:53:59 -0800 [thread overview]
Message-ID: <CAE=gft5XZD-GQYwcv4YWHrDSWRqT7SDpWXzv7c6MKAAH7uGr2Q@mail.gmail.com> (raw)
In-Reply-To: <20181030230624.61834-3-evgreen@chromium.org>
On Tue, Oct 30, 2018 at 4:06 PM Evan Green <evgreen@chromium.org> wrote:
>
> If the backing device for a loop device is a block device,
> then mirror the discard properties of the underlying block
> device into the loop device. While in there, differentiate
> between REQ_OP_DISCARD and REQ_OP_WRITE_ZEROES, which are
> different for block devices, but which the loop device had
> just been lumping together.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
Any thoughts on this patch? This fixes issues for us when using a loop
device backed by a block device, where we see many logs like:
[ 372.767286] print_req_error: I/O error, dev loop5, sector 88125696
-Evan
next prev parent reply other threads:[~2018-11-26 18:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 23:06 [PATCH 0/2] loop: Better discard for block devices Evan Green
2018-10-30 23:06 ` [PATCH 1/2] loop: Report EOPNOTSUPP properly Evan Green
2018-11-28 1:06 ` Ming Lei
2018-10-30 23:06 ` [PATCH 2/2] loop: Better discard support for block devices Evan Green
2018-11-26 18:53 ` Evan Green [this message]
2018-11-27 2:55 ` Ming Lei
2018-11-27 23:34 ` Evan Green
2018-11-28 1:28 ` Ming Lei
2018-11-28 1:26 ` Ming Lei
2018-12-04 22:19 ` Evan Green
2018-12-05 1:10 ` Ming Lei
2018-12-05 19:35 ` Evan Green
2018-12-06 0:22 ` Ming Lei
2018-12-06 3:15 ` Martin K. Petersen
2018-12-10 17:31 ` Evan Green
2018-12-18 23:48 ` Evan Green
2018-10-30 23:50 ` [PATCH 0/2] loop: Better discard " Bart Van Assche
2018-11-01 18:15 ` Evan Green
2018-11-01 22:44 ` Gwendal Grignou
2018-11-02 16:02 ` Bart Van Assche
2018-11-05 20:35 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft5XZD-GQYwcv4YWHrDSWRqT7SDpWXzv7c6MKAAH7uGr2Q@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=asavery@chromium.org \
--cc=axboe@kernel.dk \
--cc=gwendal@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).