From: Evan Green <evgreen@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Manu Gautam <mgautam@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
vivek.gautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
David Brown <david.brown@linaro.org>,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: qcom: sdm845: Fix pcs_misc region address for UNI PHY
Date: Fri, 26 Oct 2018 10:25:52 -0700 [thread overview]
Message-ID: <CAE=gft5vEfqxXhC+cADYreRGtj68PnwFnXoFknh8mP5UWYHsHQ@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=Xk0VDp2mQ9B25XXovabiHAHr=Dm1v3Pavf_iaNGOexnw@mail.gmail.com>
On Thu, Oct 25, 2018 at 1:38 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
> On Thu, Oct 25, 2018 at 10:23 AM Manu Gautam <mgautam@codeaurora.org> wrote:
> >
> > Correct address for pcs_misc register region of USB3 QMP UNI PHY.
> > These registers are used during runtime-suspend/resume routines
> > of phy.
> >
> > Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes")
> > Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index b72bdb0a31a5..84bee81562a5 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -1156,7 +1156,7 @@
> > reg = <0x88eb200 0x128>,
> > <0x88eb400 0x1fc>,
> > <0x88eb800 0x218>,
> > - <0x88e9600 0x70>;
> > + <0x88eb600 0x70>;
>
> Whoops, sorry for not noticing this earlier. Thanks for the fix!
>
> Evan's most recent patch to the bindings [1] should also be fixed
> eventually too. It feels like those patches have gone through enough
> spins though, so maybe we can just post this fix atop those?
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> [1] https://lkml.kernel.org/r/20181024172735.154304-2-evgreen@chromium.org
I'll spin mine. Incoming!
prev parent reply other threads:[~2018-10-26 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 17:23 [PATCH v1] arm64: dts: qcom: sdm845: Fix pcs_misc region address for UNI PHY Manu Gautam
2018-10-25 20:38 ` Doug Anderson
2018-10-26 17:25 ` Evan Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft5vEfqxXhC+cADYreRGtj68PnwFnXoFknh8mP5UWYHsHQ@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).