From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B19C3A5A0 for ; Mon, 20 Apr 2020 18:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 578B320782 for ; Mon, 20 Apr 2020 18:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aAUNKvGC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726498AbgDTS6i (ORCPT ); Mon, 20 Apr 2020 14:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgDTS6i (ORCPT ); Mon, 20 Apr 2020 14:58:38 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26C8FC061A0F for ; Mon, 20 Apr 2020 11:58:36 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id m8so11275445lji.1 for ; Mon, 20 Apr 2020 11:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OyRaasLaLoASyW1/WLmX+C7yyhvEwUVdH1hzQw3fL7E=; b=aAUNKvGCyrKNt32Q53YuPu83JPr2m78bZjek5JeaSOZXAWOSGrhq63lYEotLTLwyTV 2lxdxzeM41bnfDEQPDVTPB4Z22UZOiLWy8uftsHy958As20WxujgDFn06bFQ7IHSzo0F djukFCXip2VwGYwTsqmQhzPG4l+oDShfVueps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OyRaasLaLoASyW1/WLmX+C7yyhvEwUVdH1hzQw3fL7E=; b=nWa6BlKuxo6PHWz22uxdG3Jmr+6aX3lPwdpPZXFtBB35s8CSSZDII/WjATwhYYLeTJ DpBNcJjAohN/cMJUgjErn/ByEUiizMZzBoOCSgNfy5ZA4rMngKcR2zXpwC1rqPDaFXWl mahNW/9lB686pea5fw/gpMi42VXd+tn8nrXzkTCf7dUd6e8gDIt22le1sa/SQENUBzfz xrZ3UBbo/hxrZPHHEn0tT+Dm5wIE9glJQ1RkKKDH7eHIgyzVsxeZHH6yx6KBAxS9mL2V 3Cg1F4GNok5kCRxq0XodyrnaFgk2hdPanC4X9KezmzAouWzUOwy4BoD/2uz15Rkl8sju yWUQ== X-Gm-Message-State: AGi0PuYt+RiiUxFZW5pJKNl3zhy+btZVxCE6pRKgsk500gQjMRGTHImw qWX8O0zes4ua9jABGFJ711Bh4woRpik= X-Google-Smtp-Source: APiQypIrRdTTrLq94hC3cv7GotOdw8Ynh0Z5JbI481m07dODKiOcLT6XrXVcafq4ilVHcq54wBscyQ== X-Received: by 2002:a2e:b605:: with SMTP id r5mr10765657ljn.40.1587409114319; Mon, 20 Apr 2020 11:58:34 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id i20sm217132lfe.15.2020.04.20.11.58.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 11:58:33 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id f18so5232031lja.13 for ; Mon, 20 Apr 2020 11:58:33 -0700 (PDT) X-Received: by 2002:a05:651c:449:: with SMTP id g9mr11325281ljg.278.1587409112751; Mon, 20 Apr 2020 11:58:32 -0700 (PDT) MIME-Version: 1.0 References: <20200415071619.6052-1-sibis@codeaurora.org> <20200415071619.6052-2-sibis@codeaurora.org> In-Reply-To: From: Evan Green Date: Mon, 20 Apr 2020 11:57:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_mss: Remove unused q6v5_da_to_va function To: Sibi Sankar Cc: Bjorn Andersson , Andy Gross , linux-arm-msm , LKML , linux-remoteproc@vger.kernel.org, Ohad Ben Cohen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2020 at 11:53 AM Evan Green wrote: > > On Wed, Apr 15, 2020 at 12:16 AM Sibi Sankar wrote: > > > > Remove unsed q6v5_da_to_va function as the mss driver uses a per segment > > dump function. > > > > Signed-off-by: Sibi Sankar > > --- > > drivers/remoteproc/qcom_q6v5_mss.c | 14 -------------- > > 1 file changed, 14 deletions(-) > > > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > > index b781fc8de3597..6a19e0e77236e 100644 > > --- a/drivers/remoteproc/qcom_q6v5_mss.c > > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > > @@ -196,7 +196,6 @@ struct q6v5 { > > > > phys_addr_t mpss_phys; > > phys_addr_t mpss_reloc; > > - void *mpss_region; > > Hm, this doesn't build for me on our Chrome tree: > > CC [M] drivers/remoteproc/qcom_q6v5_mss.o > /mnt/host/source/src/third_party/kernel/v5.4/drivers/remoteproc/qcom_q6v5_mss.c:1118:16: > error: no member named 'mpss_region' in 'struct q6v5' > ptr = qproc->mpss_region + offset; > ~~~~~ ^ > /mnt/host/source/src/third_party/kernel/v5.4/drivers/remoteproc/qcom_q6v5_mss.c:1520:9: > error: no member named 'mpss_region' in 'struct q6v5' > qproc->mpss_region = devm_ioremap_wc(qproc->dev, > qproc->mpss_phys, qproc->mpss_size); > ~~~~~ ^ > /mnt/host/source/src/third_party/kernel/v5.4/drivers/remoteproc/qcom_q6v5_mss.c:1521:14: > error: no member named 'mpss_region' in 'struct q6v5' > if (!qproc->mpss_region) { > ~~~~~ ^ Whoops, ignore me, I missed the other patch in this series. -Evan