* [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
@ 2020-10-15 18:27 Sibi Sankar
2020-10-20 18:37 ` Evan Green
0 siblings, 1 reply; 6+ messages in thread
From: Sibi Sankar @ 2020-10-15 18:27 UTC (permalink / raw)
To: bjorn.andersson, evgreen, dianders
Cc: agross, linux-arm-msm, devicetree, linux-kernel, robh+dt, swboyd,
mka, Sibi Sankar
The modem firmware memory requirements vary between 32M/140M on
no-lte/lte skus respectively, so fixup the modem memory region
to reflect the requirements.
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
index 44956e3165a1..469aad4e5948 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
@@ -9,6 +9,10 @@
label = "proximity-wifi-lte";
};
+&mpss_mem {
+ reg = <0x0 0x86000000 0x0 0x8c00000>;
+};
+
&remoteproc_mpss {
firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn",
"qcom/sc7180-trogdor/modem/qdsp6sw.mbn";
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index bf875589d364..92a1fe114da8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -39,7 +39,7 @@
};
mpss_mem: memory@86000000 {
- reg = <0x0 0x86000000 0x0 0x8c00000>;
+ reg = <0x0 0x86000000 0x0 0x2000000>;
no-map;
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
2020-10-15 18:27 [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region Sibi Sankar
@ 2020-10-20 18:37 ` Evan Green
2020-11-09 19:18 ` Evan Green
0 siblings, 1 reply; 6+ messages in thread
From: Evan Green @ 2020-10-20 18:37 UTC (permalink / raw)
To: Sibi Sankar
Cc: Bjorn Andersson, Doug Anderson, Andy Gross, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Rob Herring, Stephen Boyd, Matthias Kaehlcke
On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <sibis@codeaurora.org> wrote:
>
> The modem firmware memory requirements vary between 32M/140M on
> no-lte/lte skus respectively, so fixup the modem memory region
> to reflect the requirements.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Evan Green <evgreen@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
2020-10-20 18:37 ` Evan Green
@ 2020-11-09 19:18 ` Evan Green
2020-11-11 4:39 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Evan Green @ 2020-11-09 19:18 UTC (permalink / raw)
To: Sibi Sankar, Bjorn Andersson
Cc: Doug Anderson, Andy Gross, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Rob Herring, Stephen Boyd, Matthias Kaehlcke
On Tue, Oct 20, 2020 at 11:37 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <sibis@codeaurora.org> wrote:
> >
> > The modem firmware memory requirements vary between 32M/140M on
> > no-lte/lte skus respectively, so fixup the modem memory region
> > to reflect the requirements.
> >
> > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>
> Reviewed-by: Evan Green <evgreen@chromium.org>
Did this land anywhere?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
2020-11-09 19:18 ` Evan Green
@ 2020-11-11 4:39 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2020-11-11 4:39 UTC (permalink / raw)
To: Evan Green
Cc: Sibi Sankar, Doug Anderson, Andy Gross, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Rob Herring, Stephen Boyd, Matthias Kaehlcke
On Mon 09 Nov 13:18 CST 2020, Evan Green wrote:
> On Tue, Oct 20, 2020 at 11:37 AM Evan Green <evgreen@chromium.org> wrote:
> >
> > On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <sibis@codeaurora.org> wrote:
> > >
> > > The modem firmware memory requirements vary between 32M/140M on
> > > no-lte/lte skus respectively, so fixup the modem memory region
> > > to reflect the requirements.
> > >
> > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> >
> > Reviewed-by: Evan Green <evgreen@chromium.org>
>
> Did this land anywhere?
Doesn't look like it, so I've picked it now. Thanks for the bump.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
2022-10-17 18:22 Stephen Boyd
@ 2022-10-27 10:14 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2022-10-27 10:14 UTC (permalink / raw)
To: Stephen Boyd
Cc: stable, Sibi Sankar, linux-kernel, patches, Evan Green,
Bjorn Andersson, Alex Elder
On Mon, Oct 17, 2022 at 11:22:41AM -0700, Stephen Boyd wrote:
> From: Sibi Sankar <sibis@codeaurora.org>
>
> commit ef9a5d188d663753e73a3c8e8910ceab8e9305c4 upstream.
>
> The modem firmware memory requirements vary between 32M/140M on
> no-lte/lte skus respectively, so fixup the modem memory region
> to reflect the requirements.
>
> Reviewed-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Link: https://lore.kernel.org/r/1602786476-27833-1-git-send-email-sibis@codeaurora.org
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Acked-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> This fixes boot of the modem on trogdor boards with the DTS from 5.10.y
> stable tree. Without this patch I run into memory assignment errors and
> then the modem fails to boot.
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region
@ 2022-10-17 18:22 Stephen Boyd
2022-10-27 10:14 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2022-10-17 18:22 UTC (permalink / raw)
To: stable
Cc: Sibi Sankar, linux-kernel, patches, Evan Green, Bjorn Andersson,
Alex Elder
From: Sibi Sankar <sibis@codeaurora.org>
commit ef9a5d188d663753e73a3c8e8910ceab8e9305c4 upstream.
The modem firmware memory requirements vary between 32M/140M on
no-lte/lte skus respectively, so fixup the modem memory region
to reflect the requirements.
Reviewed-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Link: https://lore.kernel.org/r/1602786476-27833-1-git-send-email-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Alex Elder <elder@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
This fixes boot of the modem on trogdor boards with the DTS from 5.10.y
stable tree. Without this patch I run into memory assignment errors and
then the modem fails to boot.
arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
index 44956e3165a1..469aad4e5948 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
@@ -9,6 +9,10 @@ &ap_sar_sensor {
label = "proximity-wifi-lte";
};
+&mpss_mem {
+ reg = <0x0 0x86000000 0x0 0x8c00000>;
+};
+
&remoteproc_mpss {
firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn",
"qcom/sc7180-trogdor/modem/qdsp6sw.mbn";
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 5b2a616c6257..cb2c47f13a8a 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -39,7 +39,7 @@ atf_mem: memory@80b00000 {
};
mpss_mem: memory@86000000 {
- reg = <0x0 0x86000000 0x0 0x8c00000>;
+ reg = <0x0 0x86000000 0x0 0x2000000>;
no-map;
};
base-commit: 014862eecf03f58066a957027dde73cbecdf4395
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-27 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 18:27 [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region Sibi Sankar
2020-10-20 18:37 ` Evan Green
2020-11-09 19:18 ` Evan Green
2020-11-11 4:39 ` Bjorn Andersson
2022-10-17 18:22 Stephen Boyd
2022-10-27 10:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).