From: Evan Green <evgreen@chromium.org>
To: rplsssn@codeaurora.org
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
sboyd@kernel.org, Doug Anderson <dianders@chromium.org>,
mka@chromium.org, Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH RESEND] drivers: qcom: rpmh: avoid sending sleep/wake sets immediately
Date: Wed, 24 Oct 2018 08:50:09 -0700 [thread overview]
Message-ID: <CAE=gft6o8c4abTxa3JDeUTk_xkuZmtFXCx7+Ach1E-vv-cYzMw@mail.gmail.com> (raw)
In-Reply-To: <1540315748-29158-1-git-send-email-rplsssn@codeaurora.org>
On Tue, Oct 23, 2018 at 10:29 AM Raju P.L.S.S.S.N
<rplsssn@codeaurora.org> wrote:
>
> Fix the redundant call being made to send the sleep and wake requests
> immediately to the controller.
>
> As per the patch[1], the sleep and wake request votes are cached in rpmh
> controller and sent during rpmh_flush(). These requests needs to be sent
> only during entry of deeper system low power modes or suspend.
>
> [1]https://patchwork.kernel.org/patch/10477533/
>
> Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
> ---
> drivers/soc/qcom/rpmh.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
> index e6e98d4..877fe78 100644
> --- a/drivers/soc/qcom/rpmh.c
> +++ b/drivers/soc/qcom/rpmh.c
> @@ -228,9 +228,8 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state,
> WARN_ON(irqs_disabled());
> ret = rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg);
> } else {
> - ret = rpmh_rsc_write_ctrl_data(ctrlr_to_drv(ctrlr),
> - &rpm_msg->msg);
> /* Clean up our call by spoofing tx_done */
> + ret = 0;
> rpmh_tx_done(&rpm_msg->msg, ret);
> }
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of the Code Aurora Forum, hosted by The Linux Foundation.
>
I think this makes sense to me, though the paths through here can be a
little winding.
Reviewed-by: Evan Green <evgreen@chromium.org>
next prev parent reply other threads:[~2018-10-24 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:29 [PATCH RESEND] drivers: qcom: rpmh: avoid sending sleep/wake sets immediately Raju P.L.S.S.S.N
2018-10-24 15:50 ` Evan Green [this message]
2018-10-24 17:04 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft6o8c4abTxa3JDeUTk_xkuZmtFXCx7+Ach1E-vv-cYzMw@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).