From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933044Ab2IFSjO (ORCPT ); Thu, 6 Sep 2012 14:39:14 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:64007 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373Ab2IFSjN (ORCPT ); Thu, 6 Sep 2012 14:39:13 -0400 MIME-Version: 1.0 In-Reply-To: <5048E35F.5020304@suse.cz> References: <1344929718-22736-1-git-send-email-tmshlvck@gmail.com> <1346894238-12870-1-git-send-email-tmshlvck@gmail.com> <5048E35F.5020304@suse.cz> Date: Thu, 6 Sep 2012 20:39:12 +0200 Message-ID: Subject: Re: [PATCH v6] uartclk value from serial_core exposed to sysfs From: Tomas Hlavacek To: Jiri Slaby Cc: gregkh@linuxfoundation.org, alan@linux.intel.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, marek.vasut@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Thu, Sep 6, 2012 at 7:54 PM, Jiri Slaby wrote: > On 09/06/2012 03:17 AM, Tomas Hlavacek wrote: >> @@ -2362,8 +2392,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) >> * Register the port whether it's detected or not. This allows >> * setserial to be used to alter this ports parameters. >> */ >> - tty_dev = tty_port_register_device(port, drv->tty_driver, uport->line, >> - uport->dev); >> + tty_dev = tty_register_device_attr(drv->tty_driver, uport->line, >> + uport->dev, port, tty_dev_attr_groups); > > This makes me believe you have not tested the change at all? Thanks! I can't believe I missed that. (And I actually tested that, but I have to admit that it was not enough apparently.) I will re-send the patch (after some additional testing and double-checking). Tomas