From: Janne Kanniainen <janne.kanniainen@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Bryan Wu <cooloney@gmail.com>,
rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, linux-usb@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2] leds: USB: Add support for MSI GT683R led panels
Date: Sat, 7 Jun 2014 13:12:39 +0300 [thread overview]
Message-ID: <CAEEjW04UAsi7yOdmF3FZ3sLE7m7B-VAH0prDPYjaMXarAfNwcw@mail.gmail.com> (raw)
In-Reply-To: <20140606094752.GB9307@localhost>
> First of all, please reply to the original thread and make sure to not
> drop people or lists from CC.
Sorry this is my first patch and i didn't know that. Now I know.
> For arrays you can use the ARRAY_SIZE() macro if that was the reason for
> this change. I should have mentioned that when I pointed out that you
> cannot use strlen().
That wasn't the reason. I just thought it might be better to use u64
than char[8]. I know why I can't use strlen and that was only careless
error. And there was lot of them :( I will be more careful next time.
> Where did you get these (HID report) values from by the way?
I got them by reverse engineering.
>> +
>> +static void gt683r_brightness_set(struct led_classdev *led_cdev,
>> + enum led_brightness brightness)
>> +{
>> + struct gt683r_led *led =
>> + container_of(led_cdev, struct gt683r_led, led_dev);
>> +
>> + mutex_lock(&led->lock);
>
> You cannot grab a mutex here since this function can be called from
> interrupt context (if I remember correctly). Either way, you shouldn't
> be holding the lock until the work task has finished...
I thought use asked me to put some lock there:
>> +
>> +static void gt683r_brightness_set(struct led_classdev *led_cdev,
>> + enum led_brightness brightness)
>> +{
>> + struct gt683r_led *led =
>> + container_of(led_cdev, struct gt683r_led, led_dev);
>> +
>> + led->brightness = brightness;
>
> Missing locking?
Janne
next prev parent reply other threads:[~2014-06-07 10:12 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 21:29 [PATCH v2] leds: USB: Add support for MSI GT683R led panels Janne Kanniainen
2014-06-06 9:47 ` Johan Hovold
2014-06-07 10:12 ` Janne Kanniainen [this message]
2014-06-09 11:42 ` Johan Hovold
2014-06-10 21:10 ` Janne Kanniainen
2014-06-10 21:21 ` [PATCH v3] leds: USB: HID: " Janne Kanniainen
2014-06-11 11:25 ` Jiri Kosina
2014-06-11 14:06 ` Johan Hovold
2014-06-11 14:05 ` Johan Hovold
2014-06-11 15:30 ` Johan Hovold
2014-06-11 17:34 ` Johan Hovold
2014-06-11 22:48 ` [PATCH v4] " Janne Kanniainen
2014-06-12 9:06 ` Johan Hovold
2014-06-12 20:34 ` [PATCH v5] " Janne Kanniainen
2014-06-13 7:54 ` Johan Hovold
2014-06-13 17:19 ` Janne Kanniainen
2014-06-15 14:59 ` Janne Kanniainen
2014-06-16 7:39 ` Johan Hovold
2014-06-16 17:23 ` [PATCH v6] " Janne Kanniainen
2014-06-16 22:01 ` Janne Kanniainen
2014-06-17 13:46 ` Johan Hovold
2014-06-17 16:41 ` [PATCH v8] " Janne Kanniainen
2014-06-18 7:39 ` Johan Hovold
2014-06-18 16:05 ` [PATCH v9] " Janne Kanniainen
2014-06-18 16:11 ` Johan Hovold
2014-06-18 18:41 ` Janne Kanniainen
2014-06-18 18:46 ` Johan Hovold
2014-06-18 22:10 ` Jiri Kosina
2014-06-23 14:35 ` Oliver Neukum
2014-06-23 14:42 ` Johan Hovold
2014-06-23 16:17 ` Greg KH
2014-06-23 17:16 ` [PATCH v10] " Janne Kanniainen
2014-06-23 17:27 ` Johan Hovold
2014-06-23 18:23 ` Greg KH
2014-06-23 18:24 ` Greg KH
2014-06-23 19:31 ` Johan Hovold
2014-06-23 19:40 ` Greg KH
2014-06-23 19:52 ` Johan Hovold
2014-06-23 20:24 ` Greg KH
2014-06-23 20:44 ` Johan Hovold
2014-06-24 13:10 ` Bjørn Mork
2014-06-24 14:50 ` Johan Hovold
2014-06-24 19:38 ` [PATCH 1/2] HID: leds: fix race condition in MSI GT683R driver Janne Kanniainen
2014-06-24 19:38 ` [PATCH 2/2] HID: leds: move led_mode attribute to led-class devices " Janne Kanniainen
2014-06-24 19:56 ` Greg KH
2014-06-25 11:55 ` Johan Hovold
2014-06-25 15:59 ` [PATCH 2/2 v2] HID: leds: Use attribute-groups " Janne Kanniainen
2014-06-25 17:41 ` Johan Hovold
2014-06-25 18:13 ` [PATCH 2/2 v3] HID: leds: move led_mode attribute to led-class devices " Janne Kanniainen
2014-06-30 10:39 ` Johan Hovold
2014-07-01 17:50 ` [PATCH 2/2 v4] " Janne Kanniainen
2014-07-01 20:16 ` Johan Hovold
2014-07-02 17:37 ` [PATCH 2/2 v5] " Janne Kanniainen
2014-07-03 8:28 ` Johan Hovold
2014-07-03 17:17 ` [PATCH 1/2 v6] HID: gt683r: fix race condition Janne Kanniainen
2014-07-03 17:17 ` [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices Janne Kanniainen
2014-07-03 17:40 ` Johan Hovold
2014-07-03 18:17 ` Bryan Wu
2014-07-03 18:28 ` Janne Kanniainen
2014-07-03 17:34 ` [PATCH 1/2 v6] HID: gt683r: fix race condition Johan Hovold
2014-07-03 18:13 ` Bryan Wu
2014-06-25 19:09 ` [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver Jiri Kosina
2014-06-25 22:55 ` Bryan Wu
2014-06-30 10:47 ` Johan Hovold
2014-06-30 11:33 ` Jiri Kosina
2014-06-30 23:17 ` Bryan Wu
2014-07-01 8:48 ` Johan Hovold
2014-07-01 15:48 ` Bryan Wu
2014-07-01 17:53 ` Janne Kanniainen
2014-07-02 8:56 ` Jiri Kosina
2014-06-23 16:20 ` [PATCH v9] leds: USB: HID: Add support for MSI GT683R led panels Janne Kanniainen
2014-06-14 22:42 ` [PATCH v5] " Pavel Machek
2014-06-14 23:23 ` Janne Kanniainen
2014-06-16 7:45 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEEjW04UAsi7yOdmF3FZ3sLE7m7B-VAH0prDPYjaMXarAfNwcw@mail.gmail.com \
--to=janne.kanniainen@gmail.com \
--cc=cooloney@gmail.com \
--cc=jkosina@suse.cz \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).