* [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node
@ 2020-01-06 19:10 Yangtao Li
2020-01-06 19:10 ` [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Yangtao Li
2020-01-07 8:45 ` [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Krzysztof Kozlowski
0 siblings, 2 replies; 7+ messages in thread
From: Yangtao Li @ 2020-01-06 19:10 UTC (permalink / raw)
To: robh+dt, mark.rutland, kgene, krzk, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Yangtao Li
The patch adds fimd node for tiny4412 device.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index 01f37b5ac9c4..2b62cb27420c 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -68,6 +68,14 @@
};
};
+&fimd {
+ pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+};
+
&rtc {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
2020-01-06 19:10 [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Yangtao Li
@ 2020-01-06 19:10 ` Yangtao Li
2020-01-07 9:04 ` Krzysztof Kozlowski
2020-01-07 8:45 ` [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Yangtao Li @ 2020-01-06 19:10 UTC (permalink / raw)
To: robh+dt, mark.rutland, kgene, krzk, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Yangtao Li
This patch add at070tn92 panel for tiny4412 board.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index 2b62cb27420c..57f9d09233ad 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -66,6 +66,16 @@
clock-frequency = <24000000>;
};
};
+
+ panel {
+ compatible = "innolux,at070tn92";
+
+ port {
+ panel_input: endpoint {
+ remote-endpoint = <&lcdc_output>;
+ };
+ };
+ };
};
&fimd {
@@ -74,6 +84,12 @@
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
+ port@3 {
+ reg = <3>;
+ lcdc_output: endpoint {
+ remote-endpoint = <&panel_input>;
+ };
+ };
};
&rtc {
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node
2020-01-06 19:10 [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Yangtao Li
2020-01-06 19:10 ` [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Yangtao Li
@ 2020-01-07 8:45 ` Krzysztof Kozlowski
2020-01-07 8:49 ` Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-07 8:45 UTC (permalink / raw)
To: Yangtao Li
Cc: robh+dt, mark.rutland, kgene, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote:
> The patch adds fimd node for tiny4412 device.
Hi,
Thanks for the patch.
Do not use "This patch ..." sentences but simple, imperative mode:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
Here you do not add FIMD node, because the FIMD is already there
(defined in exynos4.dtsi). You however enable it.
Enabling it without panel does not really make sense - does it work?
I guess not, so this should be squashed with second patch.
Best regards,
Krzysztof
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> index 01f37b5ac9c4..2b62cb27420c 100644
> --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> @@ -68,6 +68,14 @@
> };
> };
>
> +&fimd {
> + pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +};
> +
> &rtc {
> status = "okay";
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node
2020-01-07 8:45 ` [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Krzysztof Kozlowski
@ 2020-01-07 8:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-07 8:49 UTC (permalink / raw)
To: Yangtao Li
Cc: robh+dt, mark.rutland, kgene, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Tue, 7 Jan 2020 at 09:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote:
> > The patch adds fimd node for tiny4412 device.
>
> Hi,
>
> Thanks for the patch.
>
> Do not use "This patch ..." sentences but simple, imperative mode:
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
>
> Here you do not add FIMD node, because the FIMD is already there
> (defined in exynos4.dtsi). You however enable it.
>
> Enabling it without panel does not really make sense - does it work?
> I guess not, so this should be squashed with second patch.
... unless it really works without panel, then it makes sense to keep
it separate. However in such case, the #cells properties belong to
second patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
2020-01-06 19:10 ` [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Yangtao Li
@ 2020-01-07 9:04 ` Krzysztof Kozlowski
2020-01-07 19:07 ` Frank Lee
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-07 9:04 UTC (permalink / raw)
To: Yangtao Li
Cc: robh+dt, mark.rutland, kgene, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote:
> This patch add at070tn92 panel for tiny4412 board.
Please fix description as in patch 1.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> index 2b62cb27420c..57f9d09233ad 100644
> --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> @@ -66,6 +66,16 @@
> clock-frequency = <24000000>;
> };
> };
> +
> + panel {
> + compatible = "innolux,at070tn92";
> +
> + port {
> + panel_input: endpoint {
> + remote-endpoint = <&lcdc_output>;
> + };
> + };
> + };
> };
>
> &fimd {
> @@ -74,6 +84,12 @@
> #address-cells = <1>;
> #size-cells = <0>;
> status = "okay";
One empty space here.
> + port@3 {
> + reg = <3>;
Why starting from "3"? Why this is port@3, not just "port"?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
2020-01-07 9:04 ` Krzysztof Kozlowski
@ 2020-01-07 19:07 ` Frank Lee
2020-01-08 7:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Frank Lee @ 2020-01-07 19:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, devicetree, Linux ARM,
linux-samsung-soc, Linux Kernel Mailing List
On Tue, Jan 7, 2020 at 5:04 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote:
> > This patch add at070tn92 panel for tiny4412 board.
>
> Please fix description as in patch 1.
>
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > index 2b62cb27420c..57f9d09233ad 100644
> > --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > @@ -66,6 +66,16 @@
> > clock-frequency = <24000000>;
> > };
> > };
> > +
> > + panel {
> > + compatible = "innolux,at070tn92";
> > +
> > + port {
> > + panel_input: endpoint {
> > + remote-endpoint = <&lcdc_output>;
> > + };
> > + };
> > + };
> > };
> >
> > &fimd {
> > @@ -74,6 +84,12 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
> > status = "okay";
>
> One empty space here.
>
> > + port@3 {
> > + reg = <3>;
>
> Why starting from "3"? Why this is port@3, not just "port"?
From samsung-fimd.txt:
---
The device node can contain 'port' child nodes according to the bindings defined
in [2]. The following are properties specific to those nodes:
- reg: (required) port index, can be:
0 - for CAMIF0 input,
1 - for CAMIF1 input,
2 - for CAMIF2 input,
3 - for parallel output,
4 - for write-back interface
---
I guess it is influenced here.
https://elixir.bootlin.com/linux/v5.5-rc5/source/drivers/gpu/drm/exynos/exynos_drm_dpi.c#L170
Without it, lcd is completely black.
Your,
Yangtao
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
2020-01-07 19:07 ` Frank Lee
@ 2020-01-08 7:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-08 7:59 UTC (permalink / raw)
To: Frank Lee
Cc: Rob Herring, Mark Rutland, Kukjin Kim, devicetree, Linux ARM,
linux-samsung-soc, Linux Kernel Mailing List
On Wed, Jan 08, 2020 at 03:07:25AM +0800, Frank Lee wrote:
> On Tue, Jan 7, 2020 at 5:04 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote:
> > > This patch add at070tn92 panel for tiny4412 board.
> >
> > Please fix description as in patch 1.
> >
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > ---
> > > arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > > index 2b62cb27420c..57f9d09233ad 100644
> > > --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > > +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> > > @@ -66,6 +66,16 @@
> > > clock-frequency = <24000000>;
> > > };
> > > };
> > > +
> > > + panel {
> > > + compatible = "innolux,at070tn92";
> > > +
> > > + port {
> > > + panel_input: endpoint {
> > > + remote-endpoint = <&lcdc_output>;
> > > + };
> > > + };
> > > + };
> > > };
> > >
> > > &fimd {
> > > @@ -74,6 +84,12 @@
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > status = "okay";
> >
> > One empty space here.
> >
> > > + port@3 {
> > > + reg = <3>;
> >
> > Why starting from "3"? Why this is port@3, not just "port"?
>
> From samsung-fimd.txt:
> ---
> The device node can contain 'port' child nodes according to the bindings defined
> in [2]. The following are properties specific to those nodes:
> - reg: (required) port index, can be:
> 0 - for CAMIF0 input,
> 1 - for CAMIF1 input,
> 2 - for CAMIF2 input,
> 3 - for parallel output,
> 4 - for write-back interface
> ---
>
> I guess it is influenced here.
> https://elixir.bootlin.com/linux/v5.5-rc5/source/drivers/gpu/drm/exynos/exynos_drm_dpi.c#L170
> Without it, lcd is completely black.
Thanks for explanation.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-08 7:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 19:10 [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Yangtao Li
2020-01-06 19:10 ` [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Yangtao Li
2020-01-07 9:04 ` Krzysztof Kozlowski
2020-01-07 19:07 ` Frank Lee
2020-01-08 7:59 ` Krzysztof Kozlowski
2020-01-07 8:45 ` [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Krzysztof Kozlowski
2020-01-07 8:49 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).