From: "Carlos O'Donell" <carlos@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Darren Hart <dvhart@infradead.org>,
Maxim Samoylov <max7255@yandex-team.ru>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH] futex: send SIGBUS if argument is not aligned on a four-byte boundary
Date: Tue, 19 May 2020 13:22:48 -0400 [thread overview]
Message-ID: <CAEMqeSqr9D6uj2OB0_5uT03c_au3906z_oyhX3zfg4OempTJVw@mail.gmail.com> (raw)
In-Reply-To: <403cc691-4ec5-8b3f-382c-4820736da41d@redhat.com>
On Fri, May 15, 2020 at 1:50 PM Carlos O'Donell <carlos@redhat.com> wrote:
> This isn't fixed because this is the older code in pthread_mutex_lock
> which we haven't ported to futex-internal.h yet, otherwise we would abort
> the process.
I filed this upstream as a QoI issue so I don't forget to port the existing code
to the newer internal interfaces for futex handling.
"Bug 25997 - pthread_mutex_lock QoI issue for unaligned futex."
https://sourceware.org/bugzilla/show_bug.cgi?id=25997
I checked that -Wcast-align=strict does warn about this case, but it's
rarely used
in production code that I've worked with. I'm following up with the
compiler people
to see if we can consistently warn in these cases and so avoid this kind of code
existing in the first place.
Cheers,
Carlos.
next prev parent reply other threads:[~2020-05-19 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 15:36 [PATCH] futex: send SIGBUS if argument is not aligned on a four-byte boundary Konstantin Khlebnikov
2020-05-15 16:27 ` Peter Zijlstra
2020-05-15 17:50 ` Carlos O'Donell
2020-05-19 17:22 ` Carlos O'Donell [this message]
2020-05-19 22:53 ` Thomas Gleixner
2020-05-20 8:22 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEMqeSqr9D6uj2OB0_5uT03c_au3906z_oyhX3zfg4OempTJVw@mail.gmail.com \
--to=carlos@redhat.com \
--cc=dvhart@infradead.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max7255@yandex-team.ru \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).