From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934074AbcFIFEa (ORCPT ); Thu, 9 Jun 2016 01:04:30 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35393 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbcFIFEO (ORCPT ); Thu, 9 Jun 2016 01:04:14 -0400 MIME-Version: 1.0 In-Reply-To: References: <1465388474-20503-1-git-send-email-prasunmaiti87@gmail.com> <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> <87porrkaax.fsf@kamboji.qca.qualcomm.com> From: Prasun Maiti Date: Thu, 9 Jun 2016 10:34:12 +0530 Message-ID: Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns To: Julian Calaby Cc: "Valo, Kalle" , Linux Kernel , "ath6kl@lists.infradead.org" , Linux Next , Linux Wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Julian, It was an assumption on my part that the firmware supports a SET function. I realize it was premature to do so. I am sending another patch to convert the ath6kl_set_antenna() to a NO-OP. This will take care of the kernel warning, but would not fire any commands to firmware. I hope this solution is acceptable. Thanks, Prasun On Thu, Jun 9, 2016 at 5:35 AM, Julian Calaby wrote: > Hi Prasun, > > On Thu, Jun 9, 2016 at 1:20 AM, Prasun Maiti wrote: >> I am not sure it works fine. Like ath6kl driver send another cmd to >> firmare, I have just filled up the cmd buffer with "tx_ant", and >> "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd >> buffer to firmware. >> I have resend the patch as there are some errors in the previous patch. >> Let me know if any modifications are needed? > > Let me ask the question in another way: how do you know that the > command WMI_SET_ANTENNA_CMDID exists, has that number, takes arguments > in that format and works? > > Thanks, > > Julian Calaby > > >> On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle wrote: >>> Prasun Maiti writes: >>> >>>> No. I did not any test for that case. >>>> This driver create a new wiphy for use with cfg80211 through >>>> "wiphy_new_nm" api, but in this api, I found that more warnings for >>>> inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && >>>> !ops->get_antenna);" >>>> So, warning comes during creation of a new wiphy. That's why It is needed. >>> >>> I'm confused. Are you really saying that you added a new firmware >>> command (WMI_SET_ANTENNA_CMDID) to ath6kl but you didn't test it in any >>> way? How do you know that it works then? >>> >>> -- >>> Kalle Valo >> >> >> >> -- >> Thanks, >> Prasun >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Julian Calaby > > Email: julian.calaby@gmail.com > Profile: http://www.google.com/profiles/julian.calaby/ -- Thanks, Prasun