From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606Ab3JQGDy (ORCPT ); Thu, 17 Oct 2013 02:03:54 -0400 Received: from mail-qc0-f171.google.com ([209.85.216.171]:63691 "EHLO mail-qc0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551Ab3JQGDu (ORCPT ); Thu, 17 Oct 2013 02:03:50 -0400 MIME-Version: 1.0 In-Reply-To: <1380846199-12829-4-git-send-email-syin@broadcom.com> References: <1380846199-12829-1-git-send-email-syin@broadcom.com> <1380846199-12829-4-git-send-email-syin@broadcom.com> Date: Wed, 16 Oct 2013 23:03:49 -0700 Message-ID: Subject: Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver From: Christian Daudt To: Sherman Yin Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Linus Walleij , Grant Likely , Matt Porter , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: > Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. > > Signed-off-by: Sherman Yin > Reviewed-by: Christian Daudt > Reviewed-by: Matt Porter > --- > arch/arm/mach-bcm/Kconfig | 2 + > drivers/pinctrl/Kconfig | 10 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-capri.c | 1727 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 1740 insertions(+) > create mode 100644 drivers/pinctrl/pinctrl-capri.c > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 69d67f7..2546365 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -10,6 +10,8 @@ config ARCH_BCM > select GENERIC_CLOCKEVENTS > select GENERIC_TIME > select GPIO_BCM > + select PINCTRL > + select PINCTRL_CAPRI > select SPARSE_IRQ > select TICK_ONESHOT > select CACHE_L2X0 On your subsequent patchset pls move this from Kconfig to arm/configs/bcm_defconfig, and break that modification into a separate patch from the drivers/* modification. thanks, csd