From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFDDC76194 for ; Mon, 22 Jul 2019 23:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5334621951 for ; Mon, 22 Jul 2019 23:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BVj/vIzF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730775AbfGVXbl (ORCPT ); Mon, 22 Jul 2019 19:31:41 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34854 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727157AbfGVXbk (ORCPT ); Mon, 22 Jul 2019 19:31:40 -0400 Received: by mail-wr1-f66.google.com with SMTP id y4so41134217wrm.2; Mon, 22 Jul 2019 16:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5pckXufXtw0kEazMS+bGnT6pn8YMKIkmXZvji3FZwKI=; b=BVj/vIzFCXhHQsHdw+x5dzSlgA4ZxwmyAkvfAMgqr38V0svYnGaMpua1Iki0retPCe V03mkHO2XEHIOi/1xm0eTKCgh/C5x405zZnf1NUKb7uyQGZUnaB4pkOIhcRsn9zMpznT HmZd0I07zJk9EaQ00b+OYCtsTv/Q7gZ/20caX/Q7zK+8wZD5GV58bxO2pQQqE6sMcNo1 51K2NWGRzb952czsXat2FNenutkFEvDmcPr3QxSUW3vKxLqFgoenLSWOaY7hpg3WQivW Z7AmX3nAWbvRO0v9njXhje1BHSuIh7TwXWSpAslILH7gcYHvvQ1AyJwhFYWQGschK5Om b3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5pckXufXtw0kEazMS+bGnT6pn8YMKIkmXZvji3FZwKI=; b=JGVuzhzzTl5e4yd1qhHAAEVVztXWt8+FfImv9cQ+MiMFAwFXVC26Wd8K+RxyRoMATU dNF4OVxcqHZYJf/nhNMz0PH3Tcuu9JOT0WhU59vIdEp7Lyd40xYAC3CivUKlblmbtGkL m/Q+uFSD+E5e+ieK1+7SN04Y16HgEw77B4kzZS7MOdjG4ykKPOc+j7vdcDxQMjkmwSWa D7z/0EmRfvi9dWERB6KBYFAm89SNDJqf52Z3f20WSEmZJtzQgkcG09DMJeFkUJ0nRmIr R1JLH3ivNTBRXv9d5OxD9QtBI+llPJJihp1GvPThiPLemFFITeD447cNfQPegnq5JAiD I7dg== X-Gm-Message-State: APjAAAX1/s779oJK9/vUhuyZJzTxln4EiAHyw1iIEEHlIuRBOnMKsj3y KF2LTEvNuj+HMqewlnoCHgyJ7s4pOXWgORvWmm/9HM8UOHzGyg== X-Google-Smtp-Source: APXvYqxM/GBlgX6OTyzevsXE7dFJwn4lj7A/bNiWYqzKr41NnDKrdCa07ll9L3weUPbzsJP4k1Q+SOXFzNjSo1YRAx4= X-Received: by 2002:a5d:50d1:: with SMTP id f17mr25780575wrt.124.1563838298016; Mon, 22 Jul 2019 16:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20190723082253.33b55afe@canb.auug.org.au> In-Reply-To: <20190723082253.33b55afe@canb.auug.org.au> From: Mauro Rossi Date: Tue, 23 Jul 2019 01:31:27 +0200 Message-ID: Subject: Re: linux-next: build warning after merge of the char-misc.current tree To: Stephen Rothwell , Takashi Iwai Cc: Greg KH , Arnd Bergmann , Linux Next Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 12:23 AM Stephen Rothwell wrote: > > Hi all, > > After merging the char-misc.current tree, today's linux-next build > (arm multi_v7_defconfig) produced this warning: > > In file included from drivers/base/firmware_loader/main.c:41: > drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function] > static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; } > ^~~~~~~~~~~~~~~~ > drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function] > static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; } > ^~~~~~~~~~~~~~~~~ > > Introduced by commit > > c8917b8ff09e ("firmware: fix build errors in paged buffer handling code") > > These need to be inline (as well as static) ... :-( > > -- > Cheers, > Stephen Rothwell They were 'static inline' in the patch I have submitted for review when I reported the problem, but it was luck I am an hobbyst, not a professional coder. I checked with Takashi and Greg, because I noticed the inline removed in the post review commit and Takashi was checking if inline was really needed, now it's confirmed. No big issue, now the important thing is that inline is added, please Takashi kindly confirm when it's done. Mauro