From: Aubrey Li <aubrey.intel@gmail.com>
To: Daniel Drake <drake@endlessm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, "Li, Aubrey" <aubrey.li@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Endless Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: setup_boot_APIC_clock() NULL dereference during early boot on reduced hardware platforms
Date: Thu, 1 Aug 2019 15:16:40 +0800 [thread overview]
Message-ID: <CAERHkruxfBc8DqNUr=fbYuQWrXrHC7cK6HnVR3xp0iLA9QtxiQ@mail.gmail.com> (raw)
In-Reply-To: <CAD8Lp448i7jOk9C5NJtC2wHMaGuRLD4pxVqK17YqRCuMVXhsOA@mail.gmail.com>
On Thu, Aug 1, 2019 at 2:26 PM Daniel Drake <drake@endlessm.com> wrote:
>
> Hi,
>
> Working with a new consumer laptop based on AMD R7-3700U, we are
> seeing a kernel panic during early boot (before the display
> initializes). It's a new product and there is no previous known
> working kernel version (tested 5.0, 5.2 and current linus master).
>
> We may have also seen this problem on a MiniPC based on AMD APU 7010
> from another vendor, but we don't have it in hands right now to
> confirm that it's the exact same crash.
>
> earlycon shows the details: a NULL dereference under
> setup_boot_APIC_clock(), which actually happens in
> calibrate_APIC_clock():
>
> /* Replace the global interrupt handler */
> real_handler = global_clock_event->event_handler;
> global_clock_event->event_handler = lapic_cal_handler;
>
> global_clock_event is NULL here. This is a "reduced hardware" ACPI
> platform so acpi_generic_reduced_hw_init() has set timer_init to NULL,
> avoiding the usual codepaths that would set up global_clock_event.
>
IIRC, acpi_generic_reduced_hw_init() avoids initializing PIT, the status of
this legacy device is unknown in ACPI hw-reduced mode.
> I tried the obvious:
> if (!global_clock_event)
> return -1;
>
No, the platform needs a global clock event, can you turn on some other
clock source on your platform, like HPET?
Thanks,
-Aubrey
> However I'm probably missing part of the big picture here, as this
> only makes boot fail later on. It continues til the next point that
> something leads to schedule(), such as a driver calling msleep() or
> mark_readonly() calling rcu_barrier(), etc. Then it hangs.
>
> Is something missing in terms of timer setup here? Suggestions appreciated...
>
> Thanks
> Daniel
next prev parent reply other threads:[~2019-08-01 7:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 6:24 setup_boot_APIC_clock() NULL dereference during early boot on reduced hardware platforms Daniel Drake
2019-08-01 7:16 ` Aubrey Li [this message]
2019-08-01 7:35 ` Thomas Gleixner
2019-08-01 7:56 ` Aubrey Li
2019-08-01 8:13 ` Thomas Gleixner
2019-08-01 8:21 ` Li, Aubrey
2019-08-01 10:13 ` Thomas Gleixner
2019-08-01 15:44 ` Lendacky, Thomas
2019-08-08 20:36 ` Thomas Gleixner
2019-08-08 21:01 ` Lendacky, Thomas
2019-08-08 21:08 ` Thomas Gleixner
2019-08-08 21:36 ` Lendacky, Thomas
2019-08-09 12:54 ` [PATCH] x86/apic: Handle missing global clockevent gracefully Thomas Gleixner
2019-08-09 12:59 ` Jiri Slaby
2019-08-09 13:58 ` Lendacky, Thomas
2019-08-09 19:40 ` Thomas Gleixner
2019-08-12 6:16 ` Daniel Drake
2019-08-12 7:03 ` Jiri Slaby
2019-08-15 5:02 ` Daniel Drake
2019-08-12 7:46 ` Li, Aubrey
2019-08-12 12:24 ` Thomas Gleixner
2019-08-12 12:59 ` Aubrey Li
2019-08-12 17:11 ` Thomas Gleixner
2019-08-19 10:37 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2019-08-01 9:00 ` setup_boot_APIC_clock() NULL dereference during early boot on reduced hardware platforms Daniel Drake
2019-08-01 10:17 ` Thomas Gleixner
2019-08-01 7:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAERHkruxfBc8DqNUr=fbYuQWrXrHC7cK6HnVR3xp0iLA9QtxiQ@mail.gmail.com' \
--to=aubrey.intel@gmail.com \
--cc=aubrey.li@linux.intel.com \
--cc=drake@endlessm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).