From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751557AbdJXHI0 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 03:08:26 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:54259 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750897AbdJXHIV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 03:08:21 -0400
X-Google-Smtp-Source: ABhQp+T0jj78MwBqt6RuFBJVevB90BYvvHPcx/gsF20YgtzErUYSNK5R36IQ2Fk2NhR9sraRgYLtMDFG6IpVx1mJXLc=
MIME-Version: 1.0
In-Reply-To: <20171023121240.GE29656@lahna.fi.intel.com>
References: <1503648771-17514-1-git-send-email-bmeng.cn@gmail.com>
 <3af38787-4542-7a2b-36be-56c11b1b81f2@wedev4u.fr> <CAK8P3a3kdJiug1MaUaTzQxqayGuEGQvox-RX+NOtw0EFO7nkag@mail.gmail.com>
 <CAEUhbmXmw9uGwnAQBd2bRYvGfmCAyJFAswp33Y5LvJREB7pjmA@mail.gmail.com> <20171023121240.GE29656@lahna.fi.intel.com>
From: Bin Meng <bmeng.cn@gmail.com>
Date: Tue, 24 Oct 2017 15:08:20 +0800
Message-ID: <CAEUhbmXfN1VG8n=z4Ck-UCFqG8oT2ffaxb410v+j6OiibV2_ag@mail.gmail.com>
Subject: Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, Stefan Roese <sr@denx.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mika,

On Mon, Oct 23, 2017 at 8:12 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote:
>> > Also, the 'depends on EXPERT' statement looks misplaced,
>> > enabling EXPERT should only be there to allow you to turn
>> > extra things *off*, not to hide device drivers.
>> >
>>
>> I will leave this to Mika to comment the "EXPERT" usage. If we remove
>> this, I think that should be another patch and the documentation of
>> this driver should be updated too.
>
> Yeah, I guess we can remove that EXPERT dependency. It was added there
> exactly because I did not want ordinary users playing with the device
> and inadvertently overwrite their BIOSes (if it is not protected). I
> also agree it should be a separate patch. Do you want to do that or
> should I?

Thanks. I can prepare a patch to remove EXPERT.

Regards,
Bin