From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7923C38A2D for ; Wed, 26 Oct 2022 04:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbiJZEDU (ORCPT ); Wed, 26 Oct 2022 00:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232698AbiJZEDQ (ORCPT ); Wed, 26 Oct 2022 00:03:16 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7F73A285A for ; Tue, 25 Oct 2022 21:03:14 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id a67so39481418edf.12 for ; Tue, 25 Oct 2022 21:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2uOlcqyDGSB4FINYNMxtwAMo4ngxfOnBT6eemWeFWJ4=; b=EW9EpFTccPDUI0/2LEeGkX3N0u5lqQu2IUx8wDKOUeqskFQ4tz3dOIwmqhUMbCmBES wiFEgbHsQt8NVCcTxbIlUhhxGs/mSxBYq4BV5bzLp/meVmX/R2W6Q34qdGsfkrxVa3Iv EFBY+Mm59uimY2pz0lkIxYIlEDCTxGSWm77oU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2uOlcqyDGSB4FINYNMxtwAMo4ngxfOnBT6eemWeFWJ4=; b=Kuomz+bjvNwb6nSzbt4qGKBqV9Lt4OJtED2OgEIa5T1MoNuSZc5UYXxG8jKb3O0mwL KrgEXPTF3SjFys1TFbQmJmGVoUnihlsbCZPsD2BkGZSAyKgPtXt0b3wR9uxQFbc0KKkf K4XQCE3ajx8/3NqkjkyOgBvfPKzlBdUoPNWzvJ8JMl7lfTKS0qAmDpmNT5mQ4YHpHrem raCrUkbklIjdFZOiS/xmOBBTO33AqsyC0lFm/2TU5xgREi/fqqF3DGpQUEVWoQ89obx9 wEozCx67dMC+/KD5sTH7PKPvOyLJBBixq4iVOwGXPG0e3tI0/CBHS2QYCdcUUzapeu/7 8QWA== X-Gm-Message-State: ACrzQf2U53sXBX+AKy/g7uHYaaN2egZeBK9LO2G4ErcJbx9m+oUnaMOJ RCKguPMGoc/AypQ1HmonTQFKGrrOt9pIssZnY9bvFA== X-Google-Smtp-Source: AMsMyM72JkPtZUBNDSOZ7vAWrHE+Q6xEgcuOJDPIOW7eeHJAyW+j5W/LFwfUClpE53jDCvSgE+EJiU/tu1YGTZD6fFo= X-Received: by 2002:a05:6402:b0e:b0:461:f7a8:3e3a with SMTP id bm14-20020a0564020b0e00b00461f7a83e3amr8968352edb.372.1666756993340; Tue, 25 Oct 2022 21:03:13 -0700 (PDT) MIME-Version: 1.0 References: <20221019093215.8204-1-allen.chen@ite.com.tw> <20221019093215.8204-2-allen.chen@ite.com.tw> <20221024163748.GA1874793-robh@kernel.org> In-Reply-To: <20221024163748.GA1874793-robh@kernel.org> From: Pin-yen Lin Date: Wed, 26 Oct 2022 12:03:02 +0800 Message-ID: Subject: Re: [PATCH v5 1/2] dt-bindings: it6505: add properties to restrict output bandwidth To: allen Cc: Jau-Chih Tseng , Hermes Wu , Kenneth Hung , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Krzysztof Kozlowski , "open list:DRM DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Allen, On Tue, Oct 25, 2022 at 12:37 AM Rob Herring wrote: > > On Wed, Oct 19, 2022 at 05:32:13PM +0800, allen wrote: > > From: allen chen > > > > Add properties to restrict dp output data-lanes and clock. > > > > Signed-off-by: Pin-Yen Lin > > Signed-off-by: Allen Chen > > --- > > .../bindings/display/bridge/ite,it6505.yaml | 89 +++++++++++++++++-- > > 1 file changed, 83 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > index 833d11b2303a7..8e607b6929fc9 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > @@ -52,9 +52,70 @@ properties: > > maxItems: 1 > > description: extcon specifier for the Power Delivery > > > > - port: > > - $ref: /schemas/graph.yaml#/properties/port > > - description: A port node pointing to DPI host port node > > No existing users you are breaking? The commit msg should explain. > > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: A port node pointing to DPI host port node > > + > > + properties: > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + unevaluatedProperties: false > > + > > + properties: > > + link-frequencies: > > + minItems: 1 > > + maxItems: 1 > > + description: Allowed max link frequencies in Hz > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: Video port for DP output > > + > > + properties: > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + oneOf: > > + - minItems: 1 > > + maxItems: 1 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For one lane operation. > > + > > + - minItems: 2 > > + maxItems: 2 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For two lanes operation. > > + > > + - minItems: 4 > > + maxItems: 4 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + - 2 > > + - 3 > > + description: For four lanes operation. > > I would do just: > > data-lanes: > minItems: 1 > items: > - enum: [ 0, 1 ] > - const: 1 > - const: 2 > - const: 3 I believe we also want a `uniqueItems: true` to prevent duplicate items like `<1 1>`. Regards, Pin-yen > > It does allow 3 lanes, but I don't think that's a big deal. What it does > doesn't allow is any order and yours does. > > Rob