From: Karol Herbst <karolherbst@gmail.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
Alexandre Courbot <acourbot@nvidia.com>,
Ilia Mirkin <imirkin@alum.mit.edu>,
Julia.Lawall@lip6.fr, Martin Peres <martin.peres@free.fr>,
rspliet@eclipso.eu, Karol Herbst <nouveau@karolherbst.de>,
arnd@arndb.de, ML nouveau <nouveau@lists.freedesktop.org>,
tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, han.fei@zte.com.cn
Subject: Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies
Date: Sat, 22 Oct 2016 19:32:47 +0200 [thread overview]
Message-ID: <CAEXux-ZYknEnU=D4qA_xv162vXF4UpVG-W9eNk68ahQoPP0ozQ@mail.gmail.com> (raw)
In-Reply-To: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org>
I think it would be better to squash those commits:
1. for the includes
2. for static declerations
2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> index 34ecd4a..058ff46 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -20,6 +20,7 @@
> * DEALINGS IN THE SOFTWARE.
> */
> #include <core/device.h>
> +#include <core/firmware.h>
>
> /**
> * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
> --
> 2.7.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2016-10-22 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 9:41 [PATCH 01/17] drm/nouveau/core: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 02/17] drm/nouveau/bios: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 03/17] drm/nouveau/clk: mark symbol " Baoyou Xie
2016-10-22 9:41 ` [PATCH 04/17] drm/nouveau/fb: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 05/17] drm/nouveau/fb: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 06/17] drm/nouveau/gpio: mark symbol " Baoyou Xie
2016-10-22 9:41 ` [PATCH 07/17] drm/nouveau/secboot: " Baoyou Xie
2016-10-22 9:41 ` [PATCH 08/17] drm/nouveau/volt: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 09/17] drm/nouveau/volt: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 10/17] drm/nouveau/device: mark symbol " Baoyou Xie
2016-10-22 9:41 ` [PATCH 11/17] drm/nouveau/disp: mark symbols " Baoyou Xie
2016-10-22 9:41 ` [PATCH 12/17] drm/nouveau/fifo: " Baoyou Xie
2016-10-22 9:41 ` [PATCH 13/17] drm/nouveau/gr: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 14/17] drm/nouveau/gr: mark symbols static where possible Baoyou Xie
2016-10-22 9:41 ` [PATCH 15/17] drm/nouveau/pm: " Baoyou Xie
2016-10-22 9:41 ` [PATCH 16/17] drm/nouveau/dispnv04: add missing header dependencies Baoyou Xie
2016-10-22 9:41 ` [PATCH 17/17] drm/nouveau: mark symbols static where possible Baoyou Xie
2016-10-22 17:32 ` Karol Herbst [this message]
[not found] ` <CA+DQWkwyKzpU+oPxsz1LAPB34gQRuJGchHqzj-4262dnYdsFFw@mail.gmail.com>
2016-10-24 15:43 ` [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEXux-ZYknEnU=D4qA_xv162vXF4UpVG-W9eNk68ahQoPP0ozQ@mail.gmail.com' \
--to=karolherbst@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=acourbot@nvidia.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=han.fei@zte.com.cn \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.peres@free.fr \
--cc=nouveau@karolherbst.de \
--cc=nouveau@lists.freedesktop.org \
--cc=rspliet@eclipso.eu \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).