linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-rdma@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Ariel Elior <aelior@marvell.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Michal Kalderon <mkalderon@marvell.com>,
	Takafumi Kubota <takafumi@sslab.ics.keio.ac.jp>,
	Yuval Bason <yuval.bason@cavium.com>
Subject: Re: [PATCH] qedr: fix resource leak in qedr_create_qp
Date: Fri, 11 Sep 2020 01:31:38 +0900	[thread overview]
Message-ID: <CAEYrHj=pfGB7OuHt90t2aaawr31W9XZCHeHJurt3o0rK44jZ+A@mail.gmail.com> (raw)
In-Reply-To: <f79159af-4408-dc2f-6efa-45c5b45cf2d9@web.de>

Hi,

Thank you for your comment.
I will re-label the goto statements and post the patch as version 2.

Thanks,
Keita

2020年9月10日(木) 22:24 Markus Elfring <Markus.Elfring@web.de>:
>
> > Fix this by adding a new goto label that calls qedr_free_qp_resources.
>
> …
> > +++ b/drivers/infiniband/hw/qedr/verbs.c
> …
> > @@ -2165,11 +2187,13 @@ struct ib_qp *qedr_create_qp(struct ib_pd *ibpd,
> …
> >       return &qp->ibqp;
> >
> > +err2:
> > +     qedr_free_qp_resources(dev, qp, udata);
> >  err:
> >       kfree(qp);
>
> I propose to choose further alternatives for numbered labels.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=7fe10096c1508c7f033d34d0741809f8eecc1ed4#n485
>
> Regards,
> Markus

       reply	other threads:[~2020-09-10 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f79159af-4408-dc2f-6efa-45c5b45cf2d9@web.de>
2020-09-10 16:31 ` Keita Suzuki [this message]
2020-09-10 16:34   ` [PATCH v2] qedr: fix resource leak in qedr_create_qp Keita Suzuki
     [not found]   ` <59440849-23b1-9c69-ecf6-78f8a0b82c7a@web.de>
2020-09-11 12:49     ` [PATCH] " Keita Suzuki
2020-09-09 16:55 Keita Suzuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEYrHj=pfGB7OuHt90t2aaawr31W9XZCHeHJurt3o0rK44jZ+A@mail.gmail.com' \
    --to=keitasuzuki.park@sslab.ics.keio.ac.jp \
    --cc=Markus.Elfring@web.de \
    --cc=aelior@marvell.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mkalderon@marvell.com \
    --cc=takafumi@sslab.ics.keio.ac.jp \
    --cc=yuval.bason@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).