From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751586AbdKHIrK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 03:47:10 -0500
Received: from mail-vk0-f67.google.com ([209.85.213.67]:43615 "EHLO
        mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750760AbdKHIrH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 03:47:07 -0500
X-Google-Smtp-Source: ABhQp+So5ax3+xTTZfPIh8lab5Em1Epm7D5ArdILO1PSCV/SvICiRATngeLWUMxiKlGRiGAIaQgFGdJ/EEZNoFwmFQo=
MIME-Version: 1.0
In-Reply-To: <CAK8P3a0rHbjQw=z1mHoUDWfnzUBH+QE1CFOc4T7-rkOMM-SkLQ@mail.gmail.com>
References: <cover.1510118606.git.green.hu@gmail.com> <e0cf5501a9c31252f9d082ffe191f3e90cd4df6a.1510118606.git.green.hu@gmail.com>
 <CAK8P3a0rHbjQw=z1mHoUDWfnzUBH+QE1CFOc4T7-rkOMM-SkLQ@mail.gmail.com>
From: Greentime Hu <green.hu@gmail.com>
Date: Wed, 8 Nov 2017 16:46:26 +0800
Message-ID: <CAEbi=3eoPPtuu-PFSvj5UZiVer2n4tPSC-f7PDiWU-ZncjAP4A@mail.gmail.com>
Subject: Re: [PATCH 05/31] nds32: MMU definitions
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greentime <greentime@andestech.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Vincent Chen <vincentc@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-11-08 16:36 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu <green.hu@gmail.com> wrote:
>
>> +/*
>> + * The DMA mask corresponding to the maximum bus address allocatable
>> + * using GFP_DMA.  The default here places no restriction on DMA
>> + * allocations.  This must be the smallest DMA mask in the system,
>> + * so a successful GFP_DMA allocation will always satisfy this.
>> + */
>> +#ifndef ISA_DMA_THRESHOLD
>> +#define ISA_DMA_THRESHOLD      (0xffffffffULL)
>> +#endif
>
> I see this one only in powerpc, I think it can be removed.

Thanks. I will remove it in next version patch.

>
>> +
>> +/*
>> + * Optional device DMA address remapping. Do _not_ use directly!
>> + * We should really eliminate virt_to_bus() here - it's deprecated.
>> + */
>> +#define page_to_dma(dev, page)         ((dma_addr_t)__virt_to_phys((unsigned long)page_address(page)))
>> +#define dma_to_virt(dev, addr)         ((void *)__phys_to_virt(addr))
>> +#define virt_to_dma(dev, addr)         ((dma_addr_t)__virt_to_phys((unsigned long)(addr)))
>
> This looks like an older comment, I think we have eliminated them from the
> mainline kernel in all drivers, so you should remove them here too.

Thanks. I will remove it in next version patch.

>> diff --git a/arch/nds32/include/asm/shmparam.h b/arch/nds32/include/asm/shmparam.h
>> new file mode 100644
>> index 0000000..5679648
>> --- /dev/null
>> +++ b/arch/nds32/include/asm/shmparam.h
>
>> +
>> +/*
>> + * This should be the size of the virtually indexed cache/ways,
>> + * whichever is greater since the cache aliases every size/ways
>> + * bytes.
>> + */
>> +#define        SHMLBA  (4 * PAGE_SIZE) /* attach addr a multiple of this */
>> +#define        REALSHMLBA      SHMLBA
>
> I don't see REALSHMLBA anywhere in the kernel, do you need it?
>
> For SHMLBA, I think it should be defined as an absolute number, using
> the maximum
> that you might need for any possible value of PAGE_SIZE. Otherwise user space
> has a much harder time figuring out what it should use.

Thanks. I will remove REALSHMLBA. I will consider to use 8KB or larger
page size in the next version patch.