From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1772829-1516629368-2-15076955365527145974 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FROM 0.001, RCVD_IN_DNSWL_NONE -0.0001, RCVD_IN_MSPIKE_H3 -0.01, RCVD_IN_MSPIKE_WL -0.01, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.85.217.169', Host='mail-ua0-f169.google.com', Country='US', FromHeader='com', MailFrom='com' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: green.hu@gmail.com ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516629367; b=gtxl9GRORgQY5mOniINX7ePKLF/bkPulJ1mwNFgScVluZBN o16E3XVyL8FIAaQHrXYMULFklNviWDuT+9/GjcqHWp0tPcmKZe7t2Y3DHALiz+P9 GqCdyVJvkEW1wldwzp3/4oM+qzB18cXoanbBoPIBXxPvfXV7zk39VgjYezjgK4ke z89wpeE0me7aEJoj/njJGqD8wSTcF0nX/WYpEXxrT+9vc02mIKioIIrCykJGf8+0 xbj99asMd922ArF85xzv+mm+VpUT6ir9gRCfUa0IXNe7bnGKu3EG5l9oQ8nOYz1r ilpkHIsae37d8PASBP4sVglYW02/gUwYQ9urztg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=mime-version:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; s=arctest; t= 1516629367; bh=obNj1Hhsc5vf3QJGN+lji6cxM38MmzdC2eHf+R/Aa6A=; b=J IGt7craWd7YHsz2zVoW67fwwXPk+sVI8TzIndon33EocUuPbLfyJLEwORKCu0PMA lNc23OE7hoje8vTaQvh7egot9vdQvMqb+a0qjMCMAvIPbY42LnxFVZVhOwUe4tYk 3q3iyG6JMaY5MStoa2yl0rzNCW5z8pXuzBk+gTL0PojEiqTvDy0izFwuLjv6KojG TkvVu5VfgZ1lI0AEU/y3zRREMCpGmVKzqzjcE4gqwaIjhnuJhDkZr6lxciV4uFFg uKKKajPASPMvpFiJokxwzOJf/cJZ98GfK6W+qvJ9qjf1hZUvvh+b89M9m9tZgjnF 5yCKWpTInc5fXWnpp3sBw== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=AdMhsmO1 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.85.217.169 (mail-ua0-f169.google.com); spf=pass smtp.mailfrom=green.hu@gmail.com smtp.helo=mail-ua0-f169.google.com; x-aligned-from=pass; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=pCHKI1mZ; x-ptr=pass x-ptr-helo=mail-ua0-f169.google.com x-ptr-lookup=mail-ua0-f169.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=AdMhsmO1 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.85.217.169 (mail-ua0-f169.google.com); spf=pass smtp.mailfrom=green.hu@gmail.com smtp.helo=mail-ua0-f169.google.com; x-aligned-from=pass; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=pCHKI1mZ; x-ptr=pass x-ptr-helo=mail-ua0-f169.google.com x-ptr-lookup=mail-ua0-f169.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Google-Smtp-Source: AH8x2260vNBw/9+AdgMHLQfr5hI0ZSWnTr6UnlL2Ovmd2LGqfxMgI4PSg9ODvkXV49cBIXc7i3hZV789mPy4wDe9w58= MIME-Version: 1.0 In-Reply-To: References: From: Greentime Hu Date: Mon, 22 Jan 2018 21:55:25 +0800 Message-ID: Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings To: Arnd Bergmann Cc: Geert Uytterhoeven , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap , David Miller , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Vincent Chen , Rick Chen , Zong Li Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, Arnd: 2018-01-22 19:15 GMT+08:00 Arnd Bergmann : > On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu wrote: >> 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >>>> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>>>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: > >>>> Thank you and your example. >>>> I get it. I will update this document like this. >>>> - compatible: Should be "andestech,", "andestech,nds32v3" >>>> as fallback. >>> >>> And please keep a list of supported values of "andestech," >>> in the DT binding document, so checkpatch can validate compatible values. >>> >> >> Thank you for reminding me this. >> I will list it like this. >> >> - compatible: >> Usage: required >> Value type: >> Definition: Should be "andestech,", >> "andestech,nds32v3" as fallback. >> Examlpes with core_names are: >> "andestech,n13" >> "andestech,n15" >> "andestech,d15" >> "andestech,n10" >> "andestech,d10" > > This is still not written as a proper specification, you should not > give "examples" > but give a complete list of the available options. You could write it like: > > Must contain "andestech,nds32v3" as the most generic value, in addition to > one of the following identifiers for a particular CPU core: > "andestech,n13" > "andestech,n15" > "andestech,d15" > "andestech,n10" > "andestech,d10" > > It might be helpful to also list all other existing nds32v3 cores, > even those that the > current Linux port does not support them. > Thank you for the clear explanation. I will update it just like you wrote.