linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greentime Hu <green.hu@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Vincent Chen <deanbo422@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nds32: vdso: fix and clean-up Makefile
Date: Wed, 24 Apr 2019 15:03:50 +0800	[thread overview]
Message-ID: <CAEbi=3f2J3gOP5zOcbCsOBLS06oyWGoiVfn_ZCfUpvNHKc3HKw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASUtor7Cxq35EUrNo0qhi8Kd9Tmfgg7mfiBg=NPtgb30g@mail.gmail.com>

Masahiro Yamada <yamada.masahiro@socionext.com> 於 2019年4月18日 週四 下午5:37寫道：
>
> Hi Greentime,
>
>
> On Wed, Apr 3, 2019 at 5:38 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > - $(call if_changed,...) must have FORCE as a prerequisite
> >
> > - vdso.lds is a generated file, so it should be prefixed with
> >   $(obj)/ instead of $(src)/.
> >
> > - cmd_vdsosym is a one-liner rule, so the assignment with '='
> >   is simpler.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
>
> Ping?
>
>
> >  arch/nds32/kernel/vdso/Makefile | 8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> > index e6c50a7..01a9610 100644
> > --- a/arch/nds32/kernel/vdso/Makefile
> > +++ b/arch/nds32/kernel/vdso/Makefile
> > @@ -28,7 +28,7 @@ CPPFLAGS_vdso.lds += -P -C -U$(ARCH)
> >  $(obj)/vdso.o : $(obj)/vdso.so
> >
> >  # Link rule for the .so file, .lds has to be first
> > -$(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso)
> > +$(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
> >         $(call if_changed,vdsold)
> >
> >
> > @@ -40,9 +40,7 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
> >  # Generate VDSO offsets using helper script
> >  gen-vdsosym := $(srctree)/$(src)/gen_vdso_offsets.sh
> >  quiet_cmd_vdsosym = VDSOSYM $@
> > -define cmd_vdsosym
> > -       $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@
> > -endef
> > +      cmd_vdsosym = $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@
> >
> >  include/generated/vdso-offsets.h: $(obj)/vdso.so.dbg FORCE
> >         $(call if_changed,vdsosym)
> > @@ -65,7 +63,7 @@ gettimeofday.o : gettimeofday.c FORCE
> >
> >  # Actual build commands
> >  quiet_cmd_vdsold = VDSOL   $@
> > -      cmd_vdsold = $(CC) $(c_flags) -Wl,-n -Wl,-T $^ -o $@
> > +      cmd_vdsold = $(CC) $(c_flags) -Wl,-n -Wl,-T $(real-prereqs) -o $@
> >  quiet_cmd_vdsoas = VDSOA   $@
> >        cmd_vdsoas = $(CC) $(a_flags) -c -o $@ $<
> >  quiet_cmd_vdsocc = VDSOA   $@

Hi Yamada,

Thank you.
Acked-by: Greentime Hu <greentime@andestech.com>

      reply	other threads:[~2019-04-24  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  8:37 [PATCH] nds32: vdso: fix and clean-up Makefile Masahiro Yamada
2019-04-18  9:37 ` Masahiro Yamada
2019-04-24  7:03   ` Greentime Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEbi=3f2J3gOP5zOcbCsOBLS06oyWGoiVfn_ZCfUpvNHKc3HKw@mail.gmail.com' \
    --to=green.hu@gmail.com \
    --cc=deanbo422@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).