linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greentime Hu <green.hu@gmail.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Vincent Chen <deanbo422@gmail.com>
Subject: Re: [PATCH 07/14] nds32: ex-exit: Remove unneeded need_resched() loop
Date: Wed, 24 Apr 2019 15:18:44 +0800	[thread overview]
Message-ID: <CAEbi=3fPnEsF6hUK-p7de=+hyJ5UTF+uhb65QzNgmvNoh2TVPA@mail.gmail.com> (raw)
In-Reply-To: <20190311224752.8337-8-valentin.schneider@arm.com>

Hi Valentin,

Valentin Schneider <valentin.schneider@arm.com> 於 2019年3月12日 週二 上午6:48寫道：
>
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> ---
>  arch/nds32/kernel/ex-exit.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nds32/kernel/ex-exit.S b/arch/nds32/kernel/ex-exit.S
> index 97ba15cd4180..1df02a793364 100644
> --- a/arch/nds32/kernel/ex-exit.S
> +++ b/arch/nds32/kernel/ex-exit.S
> @@ -163,7 +163,7 @@ resume_kernel:
>         gie_disable
>         lwi     $t0, [tsk+#TSK_TI_PREEMPT]
>         bnez    $t0, no_work_pending
> -need_resched:
> +
>         lwi     $t0, [tsk+#TSK_TI_FLAGS]
>         andi    $p1, $t0, #_TIF_NEED_RESCHED
>         beqz    $p1, no_work_pending
> @@ -173,7 +173,7 @@ need_resched:
>         beqz    $t0, no_work_pending
>
>         jal     preempt_schedule_irq
> -       b       need_resched
> +       b       no_work_pending
>  #endif
>
>  /*

Thank you. :)
Acked-by: Greentime Hu <greentime@andestech.com>

  reply	other threads:[~2019-04-24  7:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 22:47 [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-03-11 22:47 ` [PATCH 01/14] sched/core: Fix preempt_schedule() interrupt return comment Valentin Schneider
2019-03-11 22:47 ` [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-03-13 17:21   ` Mark Salter
2019-03-11 22:47 ` [PATCH 03/14] csky: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 04/14] h8300: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 05/14] microblaze: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 06/14] MIPS: " Valentin Schneider
2019-03-14 18:13   ` Paul Burton
2019-03-14 18:38     ` Valentin Schneider
2019-05-10 16:16     ` Maciej W. Rozycki
2019-03-15 16:31   ` [PATCH v2] " Valentin Schneider
2019-03-19 23:18     ` Paul Burton
2019-03-11 22:47 ` [PATCH 07/14] nds32: ex-exit: " Valentin Schneider
2019-04-24  7:18   ` Greentime Hu [this message]
2019-03-11 22:47 ` [PATCH 08/14] powerpc: entry: " Valentin Schneider
2019-05-03  6:59   ` Michael Ellerman
2019-03-11 22:47 ` [PATCH 09/14] RISC-V: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 10/14] sh: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 11/14] sh64: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 12/14] sparc64: rtrap: " Valentin Schneider
2019-03-11 23:13   ` David Miller
2019-03-12  9:43     ` Valentin Schneider
2019-03-11 22:47 ` [PATCH 13/14] x86/entry: " Valentin Schneider
2019-04-05 13:13   ` [tip:x86/entry] " tip-bot for Valentin Schneider
2019-03-11 22:47 ` [PATCH 14/14] xtensa: entry: " Valentin Schneider
2019-03-12  1:10   ` Max Filippov
2019-03-12  9:45     ` Valentin Schneider
2019-03-12 18:03 ` [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Vineet Gupta
2019-03-12 18:18   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEbi=3fPnEsF6hUK-p7de=+hyJ5UTF+uhb65QzNgmvNoh2TVPA@mail.gmail.com' \
    --to=green.hu@gmail.com \
    --cc=deanbo422@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valentin.schneider@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).