* [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get
@ 2017-01-10 10:45 Augusto Mecking Caringi
2017-01-11 9:35 ` Martyn Welch
0 siblings, 1 reply; 2+ messages in thread
From: Augusto Mecking Caringi @ 2017-01-10 10:45 UTC (permalink / raw)
To: Martyn Welch
Cc: Augusto Mecking Caringi, Manohar Vanga, Greg Kroah-Hartman,
Aaron Sierra, Geliang Tang, Alessio Igor Bogani, devel,
linux-kernel
In ca91cx42_slave_get function, the value pointed by vme_base pointer is
set through:
*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);
So it must be dereferenced to be used in calculation of pci_base:
*pci_base = (dma_addr_t)*vme_base + pci_offset;
This bug was caught thanks to the following gcc warning:
drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
*pci_base = (dma_addr_t)vme_base + pci_offset;
Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
---
drivers/vme/bridges/vme_ca91cx42.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
index 6b5ee89..7cc5122 100644
--- a/drivers/vme/bridges/vme_ca91cx42.c
+++ b/drivers/vme/bridges/vme_ca91cx42.c
@@ -464,7 +464,7 @@ static int ca91cx42_slave_get(struct vme_slave_resource *image, int *enabled,
vme_bound = ioread32(bridge->base + CA91CX42_VSI_BD[i]);
pci_offset = ioread32(bridge->base + CA91CX42_VSI_TO[i]);
- *pci_base = (dma_addr_t)vme_base + pci_offset;
+ *pci_base = (dma_addr_t)*vme_base + pci_offset;
*size = (unsigned long long)((vme_bound - *vme_base) + granularity);
*enabled = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get
2017-01-10 10:45 [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get Augusto Mecking Caringi
@ 2017-01-11 9:35 ` Martyn Welch
0 siblings, 0 replies; 2+ messages in thread
From: Martyn Welch @ 2017-01-11 9:35 UTC (permalink / raw)
To: Augusto Mecking Caringi
Cc: Manohar Vanga, Greg Kroah-Hartman, Aaron Sierra, Geliang Tang,
Alessio Igor Bogani, devel, LKML
On 10 January 2017 at 10:45, Augusto Mecking Caringi
<augustocaringi@gmail.com> wrote:
> In ca91cx42_slave_get function, the value pointed by vme_base pointer is
> set through:
>
> *vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);
>
> So it must be dereferenced to be used in calculation of pci_base:
>
> *pci_base = (dma_addr_t)*vme_base + pci_offset;
>
> This bug was caught thanks to the following gcc warning:
>
> drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
> drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
> *pci_base = (dma_addr_t)vme_base + pci_offset;
>
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Acked-By: Martyn Welch <martyn@welchs.me.uk>
> ---
> drivers/vme/bridges/vme_ca91cx42.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
> index 6b5ee89..7cc5122 100644
> --- a/drivers/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/vme/bridges/vme_ca91cx42.c
> @@ -464,7 +464,7 @@ static int ca91cx42_slave_get(struct vme_slave_resource *image, int *enabled,
> vme_bound = ioread32(bridge->base + CA91CX42_VSI_BD[i]);
> pci_offset = ioread32(bridge->base + CA91CX42_VSI_TO[i]);
>
> - *pci_base = (dma_addr_t)vme_base + pci_offset;
> + *pci_base = (dma_addr_t)*vme_base + pci_offset;
> *size = (unsigned long long)((vme_bound - *vme_base) + granularity);
>
> *enabled = 0;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-11 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 10:45 [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get Augusto Mecking Caringi
2017-01-11 9:35 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).