From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D433C33CB6 for ; Thu, 23 Jan 2020 00:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FCA621835 for ; Thu, 23 Jan 2020 00:23:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kjHjZRwl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728205AbgAWAXF (ORCPT ); Wed, 22 Jan 2020 19:23:05 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:34379 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgAWAXF (ORCPT ); Wed, 22 Jan 2020 19:23:05 -0500 Received: by mail-il1-f193.google.com with SMTP id l4so397714ilj.1; Wed, 22 Jan 2020 16:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/fehjbHt+IVYClv5muhqeCjgs2EeR5SVRn+obSNfCt0=; b=kjHjZRwlmqsxGGeNme0AOQ0/17n+IzG2BfEqoxcuHH47HwtrifYlg3fL8BtTwNe49C VVeOdZNQvaBs9Mvl4BK4wVPCJSG5MrFiD0Wlkby2JA3F6k97alePmybytiMp53g8+l1X JR7vO4W0TfKZztUCOqW3/9Wfxz7YzXrvqjnYyxEG379brOXfc518/bTcpu800cTBnR7s Q8NcggkdgiKjd3SlsAvZRb1tH9sADpN9hBxhZwCGskGplo5DZrueuyTir3ifatxgT8EI TX7FOeRR6MKq4AL2eWlCSDMxy7ZcXvSSSXpEv09/pSnOUYf13up8OZVb6AUokq2oU7Fg MLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/fehjbHt+IVYClv5muhqeCjgs2EeR5SVRn+obSNfCt0=; b=f+Y4a6qiRnZPSUDWTsuAVLuQM39AtsqEhSXcSrU2tQUvArcnUcZe3tYunSsxBJQOwA 5opuiOSic5mhyAfTUGxqADtt/WPduJy+0fGtoutJ1CNzwWQ7bHA1L67J3NmcGrRgbv82 C1MRP99LDJGGOn++UMSOL5sydfChRsiGTcJ/xWE7pI4hMTQn56pru31uX96Q9f6FV4SA WdwU08RjPu+vdt10LuVXLlqA0SPKTZ62PX80HmNENNubj+PakG4G6o2tDy6aa+R1HuNW 2UBynq1HzDw0eDsl1jFt3Fxqezaqrenfx3Y5+Ixyr6ssvxRT8emSttpFny8+6pAUOU8O fxzw== X-Gm-Message-State: APjAAAWwOmYSudVemTc+cDx5jqTpdJY1r6n8mZAtWI1tVKRcz30uvUDE q6lES08PngE6eyjDZzT9xKsdq6PPX1vXtQIwpplE3Q== X-Google-Smtp-Source: APXvYqx7BXEqrkv5mOf8hdouXZDby5H+Q7RqaEErooN339jI9cftxrvDU69nbSqALoMbZsDe3TK8KYsjYkdUq5i8I3Y= X-Received: by 2002:a92:3d17:: with SMTP id k23mr10409682ila.110.1579738984350; Wed, 22 Jan 2020 16:23:04 -0800 (PST) MIME-Version: 1.0 References: <20190330081836.26942-1-biergaizi2009@gmail.com> <20190330081836.26942-2-biergaizi2009@gmail.com> In-Reply-To: <20190330081836.26942-2-biergaizi2009@gmail.com> From: Matt Turner Date: Wed, 22 Jan 2020 16:22:53 -0800 Message-ID: Subject: Re: [PATCH 1/1] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops. To: Tom Li Cc: Lee Jones , linux-mips@vger.kernel.org, Paul Burton , LKML , Yifeng Li Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 30, 2019 at 1:19 AM Tom Li wrote: > > From: Yifeng Li > > Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor, > primarily a demo platform for hobbyists and developers. It uses an > ENE KB3310B Embedded Controller with customized firmware to implement > hardware and power management. > > A monolithic platform driver code for those functionality has existed > out-of-tree for many years. This commit creates a MFD driver for the EC > chip on Yeeloong laptop to isolate EC-related code from core MIPS code, > and serves as the foundation of various subdrivers. > > NOTE: A regmap could be the reasonable abstraction for I/O, but (1) > it requires some additional refactoring to convert the shutdown/wakeup > routines in board files to subdrivers, and (2) we're only using simple > reads/writes, repmap only adds boilerplates to the existing files without > additional benefits. We simply export the EC-related functions for now, > until we come back to refactor the board files. > > Signed-off-by: Yifeng Li Did you give up on upstreaming this code? That would be a shame, and somewhat ironic given that you were frustrated about lack of review, etc, and then never responded to the review given :(