From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6903C07545 for ; Thu, 19 Oct 2023 22:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346707AbjJSWyU (ORCPT ); Thu, 19 Oct 2023 18:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346697AbjJSWyR (ORCPT ); Thu, 19 Oct 2023 18:54:17 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 979C498; Thu, 19 Oct 2023 15:54:15 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-53d9f001b35so198164a12.2; Thu, 19 Oct 2023 15:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697756054; x=1698360854; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=znKTjYCMK7qVlPe1x85VLsQxhjgS/CN/1N2ibCS0Pek=; b=ToZ/deRvOJgo7YWy09hdxkSvDUdtiNPE6yGKf7IsAh+Ao+YfgXFcKBx3vB2x8xEf+l YhNeZZPft61eii3LD7CFV7oSTZkkdtq/X4tGQDLBGVrSLt3D6JhdXugX+vFGQuIZLp3Y 9D9YsNX5QEGjPikAayXcSJxKR8AJxy55WFfZoJ2dbJLtd6bHxSCpreRNjOcRqpRaeH9f 08XdooA+mY0lmstpvCssiEJg36IUZgWzp4Yqmmf5Gm0xnCK1rBqLM4JDLx7PmxOkBSPH WT763tl1DP3/PsGKWuUw8D6owr9jLft3swwOoTidcw69I3p+jWbj97bfe1hG5JwZuvMY NdEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697756054; x=1698360854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=znKTjYCMK7qVlPe1x85VLsQxhjgS/CN/1N2ibCS0Pek=; b=nypuCifFDmRzA6zPalA3OAYXGHISLv7FBFlWH3rjIQCkm2cUcWnyZ3CpSMPt5Yz2Qz GNrHiHpDpOoJmsstts2lOj9eOw90Q3UN4QWBmuZlK5ykj1USeuQjp2NLLtv7R10fIlZi MkO3+kdpRJiiXDRFwcyeZ1nWV8SuTL0+bx/KGpT1tIg9y9UmS7WsHk/kMUPqmshgUwvo cux3kdEwpoEiQddCpRlHd227VOWKh90GMEiUc50sAvPMMq0KEUHEP35MGw595qaFr+4E hjcuam9yIYIUB57yYdWrgH8WrwY2P/rOZmkQYBQfFjZDx0HTB79B72Stpr8AlBSaHSDG +xjA== X-Gm-Message-State: AOJu0YxvBHX5I3Efyunu6QBQvk2g9ATmNtmSAM6tJ7dO68/n71XOEeo2 6ecgchJKpXWjTQYJWNHc0Y2dlLtzFVFT3zSpl73I19lp X-Google-Smtp-Source: AGHT+IHy65GTNdlUTy4eWmv1QGEZswUfHu0S4xVwjoBxCKL4FFUBpAf6AJ5h6EW3YDS7FnH5QqZ8dN+gP6T4uQF8cf8= X-Received: by 2002:ac2:5470:0:b0:500:a6c1:36f7 with SMTP id e16-20020ac25470000000b00500a6c136f7mr73421lfn.3.1697755649162; Thu, 19 Oct 2023 15:47:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrii Nakryiko Date: Thu, 19 Oct 2023 15:47:17 -0700 Message-ID: Subject: Re: [PATCH 1/1] tools build: Fix llvm feature detection, still used by bpftool To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Manu Bretelle , Adrian Hunter , Alexander Shishkin , Andi Kleen , Andrii Nakryiko , Anshuman Khandual , Carsten Haitzler , Eduard Zingerman , Fangrui Song , He Kuang , Ian Rogers , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Leo Yan , llvm@lists.linux.dev, Madhavan Srinivasan , Mark Rutland , Namhyung Kim , Nathan Chancellor , "Naveen N. Rao" , Nick Desaulniers , Peter Zijlstra , Quentin Monnet , Ravi Bangoria , Rob Herring , Tiezhu Yang , Tom Rix , Wang Nan , Wang ShaoBo , Yang Jihong , Yonghong Song , YueHaibing , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2023 at 2:17=E2=80=AFPM Arnaldo Carvalho de Melo wrote: > > When removing the BPF event for perf a feature test that checks if the > llvm devel files are availabe was removed but that is also used by > bpftool. > > bpftool uses it to decide what kind of disassembly it will use: llvm or > binutils based. > > Removing the tools/build/feature/test-llvm.cpp file made bpftool to > always fallback to binutils disassembly, even with the llvm devel files > installed, fix it by restoring just that small test-llvm.cpp test file. > > Fixes: 56b11a2126bf2f42 ("perf bpf: Remove support for embedding clang fo= r compiling BPF events (-e foo.c)") Should we route this through the bpf-next tree to get the fix for bpftool into Github mirror ASAP? > Reported-by: Manu Bretelle > Cc: Adrian Hunter > Cc: Alexander Shishkin > Cc: Andi Kleen > Cc: Andrii Nakryiko > Cc: Anshuman Khandual > Cc: Carsten Haitzler > Cc: Eduard Zingerman > Cc: Fangrui Song > Cc: He Kuang > Cc: Ian Rogers > Cc: Ingo Molnar > Cc: James Clark > Cc: Jiri Olsa > Cc: Kan Liang > Cc: Leo Yan > Cc: llvm@lists.linux.dev > Cc: Madhavan Srinivasan > Cc: Mark Rutland > Cc: Namhyung Kim > Cc: Nathan Chancellor > Cc: Naveen N. Rao > Cc: Nick Desaulniers > Cc: Peter Zijlstra > Cc: Quentin Monnet > Cc: Ravi Bangoria > Cc: Rob Herring > Cc: Tiezhu Yang > Cc: Tom Rix > Cc: Wang Nan > Cc: Wang ShaoBo > Cc: Yang Jihong > Cc: Yonghong Song > Cc: YueHaibing > Link: https://lore.kernel.org/lkml/ZTGa0Ukt7QyxWcVy@kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/build/feature/test-llvm.cpp | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 tools/build/feature/test-llvm.cpp > > diff --git a/tools/build/feature/test-llvm.cpp b/tools/build/feature/test= -llvm.cpp > new file mode 100644 > index 0000000000000000..88a3d1bdd9f6978e > --- /dev/null > +++ b/tools/build/feature/test-llvm.cpp > @@ -0,0 +1,14 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "llvm/Support/ManagedStatic.h" > +#include "llvm/Support/raw_ostream.h" > +#define NUM_VERSION (((LLVM_VERSION_MAJOR) << 16) + (LLVM_VERSION_MINOR = << 8) + LLVM_VERSION_PATCH) > + > +#if NUM_VERSION < 0x030900 > +# error "LLVM version too low" > +#endif > +int main() > +{ > + llvm::errs() << "Hello World!\n"; > + llvm::llvm_shutdown(); > + return 0; > +} > -- > 2.41.0 >