From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67804C433DF for ; Tue, 28 Jul 2020 05:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41F0720792 for ; Tue, 28 Jul 2020 05:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aK6zkF40" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgG1FsS (ORCPT ); Tue, 28 Jul 2020 01:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgG1FsR (ORCPT ); Tue, 28 Jul 2020 01:48:17 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52CA3C061794; Mon, 27 Jul 2020 22:48:17 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id l23so17671714qkk.0; Mon, 27 Jul 2020 22:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jvlM9NHcsACKHHGiZRDV7tCWZy0Y4sC2TI8QRB0PPGQ=; b=aK6zkF40KDA0bO12q53pkVpFYe+e73fEmE6vPRW+8PozxmR+lF8y8CsJDalWhutE9P GaNKLckJ683mZ66OiAoz6Hvfq9keqggBbof51sgJQ3X9y2umghAIcI+ZS3bbfdGX3ZOm RSfys2J7nUIra0LaZ/mbRJAGGpSxE4Y/L2r3ti1HGsRJtDCFgtuxbeBOWDrCaYWSe6VQ 56afX33NU9PjG9KstKRHrX/X8GUXPHI4FMwiPjzAz/HtkplWT1NYoPbXI5Dtd9fh/ih4 6dpa5xP/iyTuI0TgW536j3Cf62R984vFeQhmZ2Uw2DylCostvUzuWG7Fx1bqOA1CNKOD sKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jvlM9NHcsACKHHGiZRDV7tCWZy0Y4sC2TI8QRB0PPGQ=; b=oa9m5yVy7sy3PhhRg0Xzyxzk66Z9USkqUyPoxPebT8MTtWQS2qtGS/4ut77MmDaZFt 0HBmX/Bk9ffBIHTHTZcABKDImCuu6laD/krJLJeHaK3jVVPOcBH1nNfLMAhnXK0XvOKn h77lkW87jac/G8oAJhu0oauK0KTzG/ES5IKM1ttngkVndvJ6q+UImQulNIclDEAE97W8 4wOCx2jEn+uZppGv+Ta9vVVCqODKNO/hxKQBmhIXlyGIMIQ2myKA1xqNR1R8h/N7QHDx o7XzaN2WrHFQH0of3dpOl2ox05m/jRbmSmygUTZc2HHKo50CKNREWJ5p3zpjBqeLGJin 9MCw== X-Gm-Message-State: AOAM531kak9nE3+7lNMMW10nafEQHNNjd+NABx4xaTpuL8qMHBdmjN9/ wwJdDHZtbttN3JKuCE94jsm1QPQpvjtKM9ZJLXY= X-Google-Smtp-Source: ABdhPJzYaowpf8c8ew54cvnOj81WmjS1ctFGJrkLtq16cmtc9r7UbP0dSQjGKtifjM/IdKtliCg1nJr8KoHA19UIXBA= X-Received: by 2002:ae9:f002:: with SMTP id l2mr27590585qkg.437.1595915296590; Mon, 27 Jul 2020 22:48:16 -0700 (PDT) MIME-Version: 1.0 References: <20200727232346.0106c375@canb.auug.org.au> In-Reply-To: From: Andrii Nakryiko Date: Mon, 27 Jul 2020 22:48:05 -0700 Message-ID: Subject: Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o) To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , bpf , "netdev@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 11:58 AM Randy Dunlap wrote: > > On 7/27/20 6:23 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200724: > > > > on i386: > when CONFIG_XPS is not set/enabled: > > ld: kernel/bpf/syscall.o: in function `__do_sys_bpf': > syscall.c:(.text+0x4482): undefined reference to `bpf_xdp_link_attach' > I can't repro this on x86-64 with CONFIG_XPS unset. Do you mind sharing the exact config you've used? I see that kernel/bpf/syscall.c doesn't include linux/netdevice.h directly, so something must be preventing netdevice.h to eventually get to bpf/syscall.c, but instead of guessing on the fix, I'd like to repro it first. Thanks! > > -- > ~Randy > Reported-by: Randy Dunlap